Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

843: Mails are not forwarded to a closed PR any more #1103

Closed
wants to merge 6 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Mar 31, 2021

When bridging emails from mailing lists to pull requests, it is necessary to look at lists that can contain cross-posts as a single source. Otherwise, parts of a thread may be missed as it is only found on a certain list, while other parts are on another list. This is commonly the case for the jdk repositories which has its reviews split over many lists.

To facilitate this, a MailingList can now be sourced from multiple actual lists, and is setup in that way when bridging repositories that are configured to use multiple lists for reviews. Sending mails are now done through the MailingListServer instead, as the actual target of a mail has always been decided by the email headers, and not the list send() was invoked on.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-843: Mails are not forwarded to a closed PR any more

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1103/head:pull/1103
$ git checkout pull/1103

Update a local copy of the PR:
$ git checkout pull/1103
$ git pull https://git.openjdk.java.net/skara pull/1103/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1103

View PR using the GUI difftool:
$ git pr show -t 1103

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1103.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 31, 2021

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into pr/1095 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 31, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 31, 2021

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/1095 to master Mar 31, 2021
@rwestberg rwestberg changed the title Add support for treating a set of mboxes as a single source of conversations 843 Apr 6, 2021
@openjdk openjdk bot changed the title 843 843: Mails are not forwarded to a closed PR any more Apr 6, 2021
edvbld
edvbld approved these changes Apr 14, 2021
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Apr 14, 2021

@rwestberg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

843: Mails are not forwarded to a closed PR any more

Reviewed-by: ehelin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 14, 2021
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Apr 14, 2021

/integrate

@openjdk openjdk bot closed this Apr 14, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 14, 2021

@rwestberg Pushed as commit f8abe35.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants