Make sure Commits are closed when using Commits::stream

[JornVernee]

I noticed most places that are using Commits::stream are not actually closing the underlying resource.

I've added an onClose handler to the returned stream, and also overrode forEach (from Iterable) to call close. Unfortunately, the stream onClose handler is not called automatically when a terminal operation occurs, so we still have to use try-with-resources when using Commits::stream (which I've addressed).

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Approvers

• Erik Helin (ehelin - Reviewer)

[bridgekeeper]

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

[mlbridge]

Webrevs

• 00: Full (05de00b)

[edvbld]

Looks good, thanks for fixing this!

[openjdk]

@JornVernee This change can now be integrated. The commit message will be:

 Make sure Commits are closed when using Commits::stream

Reviewed-by: ehelin

• If you would like to add a summary, use the /summary command.
• To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

• cbe145f: Make sure Commits are closed when using Commits::stream
• 8501faf: Add topological merge bot

Your changes cannot be rebased automatically without conflicts, so you will need to merge master into your branch before integrating.

[JornVernee]

/integrate

[openjdk]

@JornVernee The following commits have been pushed to master since your change was applied:

• 8501faf

Your commit was automatically rebased without conflicts.
Pushed as commit cbe145f.