Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

905: Github UI code markdown can fail to get copied correctly into email #1112

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Apr 9, 2021

When filtering out certain markdown for sending plain-text emails, only remove multiline code formatting block markers and retain inline ones.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-905: Github UI code markdown can fail to get copied correctly into email

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1112/head:pull/1112
$ git checkout pull/1112

Update a local copy of the PR:
$ git checkout pull/1112
$ git pull https://git.openjdk.java.net/skara pull/1112/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1112

View PR using the GUI difftool:
$ git pr show -t 1112

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1112.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 9, 2021

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 905 905: Github UI code markdown can fail to get copied correctly into email Apr 9, 2021
@openjdk openjdk bot added the rfr label Apr 9, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 9, 2021

Webrevs

erikj79
erikj79 approved these changes Apr 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2021

@rwestberg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

905: Github UI code markdown can fail to get copied correctly into email

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 9, 2021
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Apr 12, 2021

/integrate

@openjdk openjdk bot closed this Apr 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 12, 2021

@rwestberg Since your change was applied there has been 1 commit pushed to the master branch:

  • d9b551d: 769: Replies to e-mail comments on GitHub are threaded incorrectly

Your commit was automatically rebased without conflicts.

Pushed as commit 1137b55.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants