Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update to Gradle 7.0 #1113

Closed
wants to merge 2 commits into from
Closed

build: update to Gradle 7.0 #1113

wants to merge 2 commits into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Apr 12, 2021

Hi all,

please review this patch that updates Gradle to version 7.0. Gradle is a bit stricter in 7.0 when it comes to consuming task output, so I had to ensure that the Output properties per task were unique.

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1113/head:pull/1113
$ git checkout pull/1113

Update a local copy of the PR:
$ git checkout pull/1113
$ git pull https://git.openjdk.java.net/skara pull/1113/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1113

View PR using the GUI difftool:
$ git pr show -t 1113

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1113.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 12, 2021

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 12, 2021

Webrevs

@openjdk openjdk bot mentioned this pull request Apr 12, 2021
4 tasks
@openjdk
Copy link

@openjdk openjdk bot commented Apr 12, 2021

@edvbld This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

build: update to Gradle 7.0

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 12, 2021
@edvbld
Copy link
Member Author

@edvbld edvbld commented Apr 14, 2021

/integrate

@openjdk openjdk bot closed this Apr 14, 2021
@openjdk openjdk bot added integrated and removed ready labels Apr 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 14, 2021

@edvbld Since your change was applied there have been 2 commits pushed to the master branch:

  • ea2dc18: 965: hgupdate-sync mistakenly added to 16.0.2 backport record
  • 995a858: 964: Should only consider Fixed bugs for hgupdate-sync

Your commit was automatically rebased without conflicts.

Pushed as commit 0a79bfc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants