Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to JDK 16 #1114

Closed
wants to merge 2 commits into from
Closed

Update to JDK 16 #1114

wants to merge 2 commits into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Apr 12, 2021

Hi all,

please review this patch that updates the JDK used for building and running Skara to JDK 16. As part of the update I had to remove --illegal-access=deny from Skara's module plugin and I also had use LogRecord.getLongThreadId instead of the (since JDK 16) deprecated method LogRecord.getThreadId.

Testing:

  • make images locally
  • make test locally

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1114/head:pull/1114
$ git checkout pull/1114

Update a local copy of the PR:
$ git checkout pull/1114
$ git pull https://git.openjdk.java.net/skara pull/1114/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1114

View PR using the GUI difftool:
$ git pr show -t 1114

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1114.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 12, 2021

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into pr/1113 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 12, 2021

Webrevs

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/1113 to master Apr 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 14, 2021

@edvbld This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

Update to JDK 16

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • e3b75ff: 963: Skara mlbridge bot sometimes resends old messages
  • f8abe35: 843: Mails are not forwarded to a closed PR any more
  • 0a79bfc: build: update to Gradle 7.0
  • ea2dc18: 965: hgupdate-sync mistakenly added to 16.0.2 backport record
  • 995a858: 964: Should only consider Fixed bugs for hgupdate-sync

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 14, 2021
@edvbld
Copy link
Member Author

@edvbld edvbld commented Apr 17, 2021

/integrate

@openjdk openjdk bot closed this Apr 17, 2021
@openjdk openjdk bot added integrated and removed ready labels Apr 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 17, 2021

@edvbld Since your change was applied there have been 8 commits pushed to the master branch:

  • 24e7dd3: 973: Include namespaces in census unification
  • 64a8dc1: 930: Skara bot adds confusing comment to PR when CSR is needed
  • 132acee: 934: Bots incorrectly assigned "build" label despite no obvious matching rule
  • e3b75ff: 963: Skara mlbridge bot sometimes resends old messages
  • f8abe35: 843: Mails are not forwarded to a closed PR any more
  • 0a79bfc: build: update to Gradle 7.0
  • ea2dc18: 965: hgupdate-sync mistakenly added to 16.0.2 backport record
  • 995a858: 964: Should only consider Fixed bugs for hgupdate-sync

Your commit was automatically rebased without conflicts.

Pushed as commit 3e1e805.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants