Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

930: Skara bot adds confusing comment to PR when CSR is needed #1119

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Apr 15, 2021

Hi all,

please review this patch that slightly changes the wording in the message from the /csr command when the user has to create a CSR. When a CSR is created in JBS then it is automatically linked to the issue, so there is no need to instruct the user to link the CSR to an issue. I therefore just removed this part from the reply.

Testing:

  • make test passes locally on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-930: Skara bot adds confusing comment to PR when CSR is needed

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1119/head:pull/1119
$ git checkout pull/1119

Update a local copy of the PR:
$ git checkout pull/1119
$ git pull https://git.openjdk.java.net/skara pull/1119/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1119

View PR using the GUI difftool:
$ git pr show -t 1119

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1119.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 15, 2021

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title skara-930 930: Skara bot adds confusing comment to PR when CSR is needed Apr 15, 2021
@openjdk openjdk bot added the rfr label Apr 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 15, 2021

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Apr 15, 2021

@edvbld This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

930: Skara bot adds confusing comment to PR when CSR is needed

Reviewed-by: rwestberg, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 15, 2021
Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good.

@edvbld
Copy link
Member Author

@edvbld edvbld commented Apr 16, 2021

/integrate

@openjdk openjdk bot closed this Apr 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@edvbld Pushed as commit 64a8dc1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants