930: Skara bot adds confusing comment to PR when CSR is needed #1119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hi all,
please review this patch that slightly changes the wording in the message from the
/csr
command when the user has to create a CSR. When a CSR is created in JBS then it is automatically linked to the issue, so there is no need to instruct the user to link the CSR to an issue. I therefore just removed this part from the reply.Testing:
make test
passes locally on Linux x64Thanks,
Erik
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1119/head:pull/1119
$ git checkout pull/1119
Update a local copy of the PR:
$ git checkout pull/1119
$ git pull https://git.openjdk.java.net/skara pull/1119/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1119
View PR using the GUI difftool:
$ git pr show -t 1119
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1119.diff