New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SKARA-971: Stop clumping up logs in logstash #1120
Conversation
|
Webrevs
|
Looks good, this is probably how it should have been done from the beginning!
bots/cli/src/main/java/org/openjdk/skara/bots/cli/BotLogstashHandler.java
Outdated
Show resolved
Hide resolved
@erikj79 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
…andler.java Co-authored-by: Robin Westberg <robin@westberg.se>
bots/cli/src/main/java/org/openjdk/skara/bots/cli/BotLogstashHandler.java
Outdated
Show resolved
Hide resolved
bots/cli/src/main/java/org/openjdk/skara/bots/cli/BotLogstashHandler.java
Outdated
Show resolved
Hide resolved
/integrate |
@erikj79 Since your change was applied there have been 3 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 7a7d15b. |
I would like to change how we send logs to logstash so each log message is stored as an individual document. To make this more practical, we need to add some more meta data to each message so we can properly filter them. I suggest adding the following:
instance_start_time: An ISO_INSTANT time stamp string indicating when this JVM instance was started.
work_id: A running counter generated ID for each work item, rest request or periodic check, which was previously clumped up in one log message.
work_item: For work items, store the item toString()
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1120/head:pull/1120
$ git checkout pull/1120
Update a local copy of the PR:
$ git checkout pull/1120
$ git pull https://git.openjdk.java.net/skara pull/1120/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1120
View PR using the GUI difftool:
$ git pr show -t 1120
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1120.diff