Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr: markdown fixes for /backport #1126

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -173,7 +173,7 @@ public void handle(PullRequestBot bot, HostedCommit commit, CensusInstance censu
"[" + hash.abbreviate() + "](" + commit.url() + ") from the " +
"[" + currentRepoName + "](" + bot.repo().webUrl() + ") repository.");
body.add(">");
var info = "The commit being backported was authored by " + commit.author().name() + " on " +
var info = "> The commit being backported was authored by " + commit.author().name() + " on " +
commit.committed().format(formatter);
if (message.reviewers().isEmpty()) {
info += " and had no reviewers";
@@ -182,11 +182,7 @@ public void handle(PullRequestBot bot, HostedCommit commit, CensusInstance censu
.stream()
.map(r -> censusInstance.census().contributor(r))
.map(c -> {
var link = "[" + c.username() + "](https://openjdk.java.net/census#" +
c.username() + ")";
return c.fullName().isPresent() ?
c.fullName().get() + " (" + link + ")" :
link;
return c.fullName().isPresent() ? c.fullName().get() : c.username();
})
.collect(Collectors.toList());
var numReviewers = reviewers.size();
@@ -221,6 +217,7 @@ public void handle(PullRequestBot bot, HostedCommit commit, CensusInstance censu
"\n" +
String.join("\n", body) +
"\n" +
"\n" +
"If you need to update the [source branch](" + backportBranchWebUrl + ") of the pull " +
"then run the following commands in a local clone of your personal fork of " +
"[" + targetRepo.name() + "](" + targetRepo.webUrl() + "):\n" +
@@ -231,7 +228,7 @@ public void handle(PullRequestBot bot, HostedCommit commit, CensusInstance censu
"# make changes\n" +
"$ git add paths/to/changed/files\n" +
"$ git commit --message 'Describe additional changes made'\n" +
"$ git push\n" +
"$ git push " + fork.webUrl() + " " + backportBranchName + "\n" +
"```");
} catch (IOException e) {
throw new UncheckedIOException(e);