Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

980: Update log level of thrown exceptions #1132

Closed
wants to merge 2 commits into from

Conversation

erikj79
Copy link
Member

@erikj79 erikj79 commented Apr 20, 2021

This patch updates (almost) all uses of log.throwing() to log.log() so that we can include any exception in a log message of the appropriate level. This became necessary as we started logging each log message individually to logstash, so the FINER level logs from log.throwing() were no longer included.

In addition to this, I'm also adding stack_trace and logger_name as fields in the logstash logging entries.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-980: Update log level of thrown exceptions

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1132/head:pull/1132
$ git checkout pull/1132

Update a local copy of the PR:
$ git checkout pull/1132
$ git pull https://git.openjdk.java.net/skara pull/1132/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1132

View PR using the GUI difftool:
$ git pr show -t 1132

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1132.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 20, 2021

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title SKARA-980 980: Update log level of thrown exceptions Apr 20, 2021
@openjdk openjdk bot added the rfr label Apr 20, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 20, 2021

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

bot/src/main/java/org/openjdk/skara/bot/BotRunner.java Outdated Show resolved Hide resolved
@openjdk
Copy link

@openjdk openjdk bot commented Apr 21, 2021

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

980: Update log level of thrown exceptions

Reviewed-by: rwestberg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 8441a35: 831: Longer time for autoclose on passive PRs
  • aa132b8: 974: Add retry logic to mlbridge when pushing

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 21, 2021
Co-authored-by: Robin Westberg <robin@westberg.se>
@erikj79
Copy link
Member Author

@erikj79 erikj79 commented Apr 21, 2021

/integrate

@openjdk openjdk bot closed this Apr 21, 2021
@openjdk openjdk bot added integrated and removed ready labels Apr 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 21, 2021

@erikj79 Since your change was applied there have been 2 commits pushed to the master branch:

  • 8441a35: 831: Longer time for autoclose on passive PRs
  • aa132b8: 974: Add retry logic to mlbridge when pushing

Your commit was automatically rebased without conflicts.

Pushed as commit 7cdcc9d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants