New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
980: Update log level of thrown exceptions #1132
Conversation
…ger name in logstash logs.
|
Webrevs
|
@erikj79 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
Co-authored-by: Robin Westberg <robin@westberg.se>
/integrate |
@erikj79 Since your change was applied there have been 2 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 7cdcc9d. |
This patch updates (almost) all uses of log.throwing() to log.log() so that we can include any exception in a log message of the appropriate level. This became necessary as we started logging each log message individually to logstash, so the FINER level logs from log.throwing() were no longer included.
In addition to this, I'm also adding stack_trace and logger_name as fields in the logstash logging entries.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1132/head:pull/1132
$ git checkout pull/1132
Update a local copy of the PR:
$ git checkout pull/1132
$ git pull https://git.openjdk.java.net/skara pull/1132/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1132
View PR using the GUI difftool:
$ git pr show -t 1132
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1132.diff