1003: GitHubRepository.restrictAccess sends incomplete query

[edvbld]

Hi all,

please review this patch which sends the correct JSON data to GitHub's branch protection endpoint. I also changed the API of restrictPushAccess to make it more clear that only the supplied HostUser can push to the given branch afterwards.

Thanks,
Erik

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Issue

• SKARA-1003: GitHubRepository.restrictAccess sends incomplete query

Reviewers

• Robin Westberg (@rwestberg - Reviewer)
• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1141/head:pull/1141
$ git checkout pull/1141

Update a local copy of the PR:
$ git checkout pull/1141
$ git pull https://git.openjdk.java.net/skara pull/1141/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1141

View PR using the GUI difftool:
$ git pr show -t 1141

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1141.diff

[bridgekeeper]

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (69265625)

[rwestberg]

Looks good!

[openjdk]

@edvbld This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

1003: GitHubRepository.restrictAccess sends incomplete query

Reviewed-by: rwestberg, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• d27723d: 1004: Skara bots fail to parse openjfx11.0.12 version
• 7b3d557: 998: Backport fails for jdk15u-dev

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[edvbld]

/integrate

[openjdk]

@edvbld Since your change was applied there have been 2 commits pushed to the master branch:

• d27723d: 1004: Skara bots fail to parse openjfx11.0.12 version
• 7b3d557: 998: Backport fails for jdk15u-dev

Your commit was automatically rebased without conflicts.

Pushed as commit 62e23e0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.