New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1004: Skara bots fail to parse openjfx11.0.12 version #1142
Conversation
👋 Welcome back erikj! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@erikj79 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. 🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it. 🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This should work. With this fix, is |
It will still be needed for versions that contain an 'u' I guess, so depends on whether you use jdk8-style versions (8u297 etc) or not. |
/integrate |
This patch adds the ability to parse prefixes for JEP322 versions in JBS. One typical such prefix is openjfx, but I chose to not enumerate valid ones here but instead accept any prefix matching [a-z]+.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1142/head:pull/1142
$ git checkout pull/1142
Update a local copy of the PR:
$ git checkout pull/1142
$ git pull https://git.openjdk.java.net/skara pull/1142/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1142
View PR using the GUI difftool:
$ git pr show -t 1142
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1142.diff