Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1011: Allow JDK fixVersion to be XXu-cpu #1144

wants to merge 1 commit into from


Copy link

@erikj79 erikj79 commented May 3, 2021

We would like to be able to use fixVersions in JBS on the form "16u-cpu". This PR contains the necessary changes needed to the JdkVersion class to handle such versions. I'm also adding test cases to verify that it behaves as we want it.


  • Change must not contain extraneous whitespace
  • Change must be properly reviewed




Using git

Checkout this PR locally:
$ git fetch pull/1144/head:pull/1144
$ git checkout pull/1144

Update a local copy of the PR:
$ git checkout pull/1144
$ git pull pull/1144/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1144

View PR using the GUI difftool:
$ git pr show -t 1144

Using diff file

Download this PR as a diff file:

Copy link

@bridgekeeper bridgekeeper bot commented May 3, 2021

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title SKARA-1011 1011: Allow JDK fixVersion to be XXu-cpu May 3, 2021
@openjdk openjdk bot added the rfr label May 3, 2021
Copy link

@mlbridge mlbridge bot commented May 3, 2021


edvbld approved these changes May 4, 2021
Copy link

@edvbld edvbld left a comment

Looks good!

Copy link

@openjdk openjdk bot commented May 4, 2021

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

1011: Allow JDK fixVersion to be XXu-cpu

Reviewed-by: ehelin, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 4, 2021
Copy link
Member Author

@erikj79 erikj79 commented May 4, 2021


@openjdk openjdk bot closed this May 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 4, 2021
Copy link

@openjdk openjdk bot commented May 4, 2021

@erikj79 Pushed as commit 2694859.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants