Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forge: fix GitHubRepository.createPullRequestUrl #1145

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented May 4, 2021

Hi all,

please review this patch that fixes GitHubRepository.createPullRequestUrl (I had forgotten a /pull/) in the URL. Thanks to @RealCLanger for finding this!

Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1145/head:pull/1145
$ git checkout pull/1145

Update a local copy of the PR:
$ git checkout pull/1145
$ git pull https://git.openjdk.java.net/skara pull/1145/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1145

View PR using the GUI difftool:
$ git pr show -t 1145

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1145.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 4, 2021

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 4, 2021
Copy link
Contributor

@RealCLanger RealCLanger left a comment

LGTM - as far as I can tell :)

@mlbridge
Copy link

mlbridge bot commented May 4, 2021

Webrevs

erikj79
erikj79 approved these changes May 4, 2021
@openjdk
Copy link

openjdk bot commented May 4, 2021

@edvbld This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

forge: fix GitHubRepository.createPullRequestUrl

Reviewed-by: clanger, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 2694859: 1011: Allow JDK fixVersion to be XXu-cpu

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 4, 2021
@edvbld
Copy link
Member Author

edvbld commented May 4, 2021

/integrate

@openjdk openjdk bot closed this May 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 4, 2021
@openjdk
Copy link

openjdk bot commented May 4, 2021

@edvbld Since your change was applied there has been 1 commit pushed to the master branch:

  • 2694859: 1011: Allow JDK fixVersion to be XXu-cpu

Your commit was automatically rebased without conflicts.

Pushed as commit 7f2c2e4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants