1019: IssueNotifier fails if there are extra branches in a repo

[erikj79]

This change makes the notifier bot more lenient when finding branches without fixVersions configured, or when those fixVersions do not have backports in the issue tracker, when processing new tags. Currently either of these cases will cause the rest of the commits affected by a tag to never get processed. See bug for more details.

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Issue

• SKARA-1019: IssueNotifier fails if there are extra branches in a repo

Reviewers

• Kevin Rushforth (@kevinrushforth - no project role)
• Erik Helin (@edvbld - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1147/head:pull/1147
$ git checkout pull/1147

Update a local copy of the PR:
$ git checkout pull/1147
$ git pull https://git.openjdk.java.net/skara pull/1147/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1147

View PR using the GUI difftool:
$ git pr show -t 1147

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1147.diff

[bridgekeeper]

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (76cc3e20)

[kevinrushforth]

lgtm

[edvbld]

Looks good!

[openjdk]

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

1019: IssueNotifier fails if there are extra branches in a repo

Reviewed-by: kcr, ehelin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[edvbld]

This is definitely a reasonable approach. An alternative approach if you want to be a bit more safe would be to configure some branches with an ignore value. That way the notifier will know if a branch is supposed to e.g. have a fixVersion or not. That way we will still get the exceptions for cases when a branch does not have a configured fixVersion nor is configured to be ignored.

[erikj79]

/integrate

[openjdk]

@erikj79 Pushed as commit 3ec0893.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.