Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the repository configuration syntax #116

Closed
wants to merge 1 commit into from

Conversation

@rwestberg
Copy link
Member

rwestberg commented Sep 3, 2019

Hi all,

Please review this change that extends the BotRunner configuration parsing of repository names. Previously, every repository had to be described one time for each host/credential set it was to be used with. Now it is allowed to specify this directly as a string of the form <host definition name>/<actual repository name>. Additionally, a ref name can optionally be appended of the form :<ref name> at the end of the string.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)
@bridgekeeper

This comment has been minimized.

Copy link

bridgekeeper bot commented Sep 3, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Sep 3, 2019
@mlbridge

This comment has been minimized.

Copy link

mlbridge bot commented Sep 3, 2019

Webrevs

@edvbld
edvbld approved these changes Sep 3, 2019
Copy link
Member

edvbld left a comment

Obviously correct 😄 Thanks for the tests!

@openjdk openjdk bot removed the rfr label Sep 3, 2019
@openjdk

This comment has been minimized.

Copy link

openjdk bot commented Sep 3, 2019

@rwestberg This change can now be integrated. The commit message will be:

Extend the repository configuration syntax

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 2aa4482: Extend the repository configuration syntax

Your changes cannot be rebased automatically without conflicts, so you will need to merge master into your branch before integrating.

@openjdk openjdk bot added the ready label Sep 3, 2019
@rwestberg

This comment has been minimized.

Copy link
Member Author

rwestberg commented Sep 3, 2019

/integrate

@openjdk openjdk bot closed this Sep 3, 2019
@openjdk openjdk bot added the integrated label Sep 3, 2019
@openjdk

This comment has been minimized.

Copy link

openjdk bot commented Sep 3, 2019

@rwestberg Pushed as commit 2aa4482.

@openjdk openjdk bot added the outdated label Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.