Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bot: add profile handler #1164

Closed
wants to merge 3 commits into from
Closed

bot: add profile handler #1164

wants to merge 3 commits into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented May 24, 2021

Hi all,

please review this patch that adds a "profiling handler" typically listening on the /profile path. The profile handler will create a JFR recording that is sent as the reply to the HTTP request. The handler needs to configure a max duration (in seconds) for the recording and and a path to the .jfc configuration file. I made sure that only recording is allowed at a time to prevent too many requests to slow down the system too much.

Testing:

  • Tested locally on Linux x64 with various bots and configurations

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1164/head:pull/1164
$ git checkout pull/1164

Update a local copy of the PR:
$ git checkout pull/1164
$ git pull https://git.openjdk.java.net/skara pull/1164/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1164

View PR using the GUI difftool:
$ git pr show -t 1164

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1164.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 24, 2021

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 24, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 24, 2021

Webrevs

@openjdk openjdk bot mentioned this pull request May 24, 2021
3 tasks
@openjdk
Copy link

@openjdk openjdk bot commented May 28, 2021

@edvbld This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

bot: add profile handler

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 28, 2021
@edvbld
Copy link
Member Author

@edvbld edvbld commented May 28, 2021

/integrate

@openjdk openjdk bot closed this May 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 28, 2021

@edvbld Since your change was applied there have been 12 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 92bf2dc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants