New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bot: add profile handler #1164
bot: add profile handler #1164
Conversation
|
Webrevs
|
@edvbld This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
@edvbld Since your change was applied there have been 12 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 92bf2dc. |
Hi all,
please review this patch that adds a "profiling handler" typically listening on the
/profile
path. The profile handler will create a JFR recording that is sent as the reply to the HTTP request. The handler needs to configure a max duration (in seconds) for the recording and and a path to the.jfc
configuration file. I made sure that only recording is allowed at a time to prevent too many requests to slow down the system too much.Testing:
Thanks,
Erik
Progress
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1164/head:pull/1164
$ git checkout pull/1164
Update a local copy of the PR:
$ git checkout pull/1164
$ git pull https://git.openjdk.java.net/skara pull/1164/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1164
View PR using the GUI difftool:
$ git pr show -t 1164
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1164.diff