Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: add process metrics #1175

Closed
wants to merge 1 commit into from
Closed

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented May 27, 2021

Hi all,

please review this patch that adds the Prometheus recommended process_* metrics. I've tested the implementation manually on a Linux x64 machine and opted to start by only implementing support for all metrics on Linux hosts.

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1175/head:pull/1175
$ git checkout pull/1175

Update a local copy of the PR:
$ git checkout pull/1175
$ git pull https://git.openjdk.java.net/skara pull/1175/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1175

View PR using the GUI difftool:
$ git pr show -t 1175

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1175.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 27, 2021

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 27, 2021
@mlbridge
Copy link

mlbridge bot commented May 27, 2021

Webrevs

Copy link
Member

@erikj79 erikj79 left a comment

Looks good.

@openjdk
Copy link

openjdk bot commented May 27, 2021

@edvbld This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

metrics: add process metrics

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 2863b96: Update readme
  • b54fecb: 1061: The skara update command is broken for platforms without downloaded JDK
  • 2eb3dab: 1053: Github check in conclusion "stale" not handled

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 27, 2021
@edvbld
Copy link
Member Author

edvbld commented May 28, 2021

/integrate

@openjdk openjdk bot closed this May 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 28, 2021
@openjdk
Copy link

openjdk bot commented May 28, 2021

@edvbld Since your change was applied there have been 3 commits pushed to the master branch:

  • 2863b96: Update readme
  • b54fecb: 1061: The skara update command is broken for platforms without downloaded JDK
  • 2eb3dab: 1053: Github check in conclusion "stale" not handled

Your commit was automatically rebased without conflicts.

Pushed as commit f348984.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants