Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1056: Mirror service is no longer syncing tags #1177

Closed
wants to merge 1 commit into from

Conversation

erikj79
Copy link
Member

@erikj79 erikj79 commented May 28, 2021

We currently have two modes of mirroring repositories using the MirrorBot, either a set of branches, or everything. When limiting branches, tags are excluded, and when mirroring everything, tags are included.

I'm adding a new configuration option "tags": true/false. The purpose is to be able to include tags when only mirroring a set of branches. Default is false (to mimic current behavior). I can't see a use case for being able to exclude tags in the all branches case, and implementing it would add quite a bit of complexity.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-1056: Mirror service is no longer syncing tags

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1177/head:pull/1177
$ git checkout pull/1177

Update a local copy of the PR:
$ git checkout pull/1177
$ git pull https://git.openjdk.java.net/skara pull/1177/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1177

View PR using the GUI difftool:
$ git pr show -t 1177

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1177.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 28, 2021

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title SKARA-1056 1056: Mirror service is no longer syncing tags May 28, 2021
@openjdk openjdk bot added the rfr label May 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 28, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2021

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

1056: Mirror service is no longer syncing tags

Reviewed-by: tbell, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 8998a07: 1065: New prometheus labels have illegal characters
  • 2cc7436: 1031: Declare Skara 1.0

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 2, 2021
@erikj79
Copy link
Member Author

@erikj79 erikj79 commented Jun 2, 2021

/integrate

@openjdk openjdk bot closed this Jun 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2021

@erikj79 Since your change was applied there have been 2 commits pushed to the master branch:

  • 8998a07: 1065: New prometheus labels have illegal characters
  • 2cc7436: 1031: Declare Skara 1.0

Your commit was automatically rebased without conflicts.

Pushed as commit f8e97f7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants