Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and cleanup #1185

Closed
wants to merge 2 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -46,7 +46,7 @@ external Git source code hosting providers are available:

## Building

[JDK 15](http://jdk.java.net/15/) or later and [Gradle](https://gradle.org/)
[JDK 14](http://jdk.java.net/14/) or later and [Gradle](https://gradle.org/)
6.6 or later is required for building. To build the project on macOS or
GNU/Linux x64, just run the following command from the source tree root:

@@ -69,7 +69,7 @@ also want to build the bot images run `sh gradlew images` on GNU/Linux or

If you want to build on an operating system other than GNU/Linux, macOS or
Windows _or_ if you want to build on a CPU architecture other than x64, then
ensure that you have JDK 15 or later installed locally and JAVA_HOME set to
ensure that you have JDK 14 or later installed locally and JAVA_HOME set to
point to it. You can then run the following command from the source tree root:

```bash
@@ -84,7 +84,7 @@ tree root.
If you don't want the build to automatically download any dependencies, then
you must ensure that you have installed the following software locally:

- JDK 15 or later
- JDK 14 or later
- Gradle 6.6 or later

To create a build then run the command:
@@ -224,7 +224,7 @@ or IDE.
If you choose to use [IntelliJ IDEA](https://www.jetbrains.com/idea/) as your
IDE when working on Skara you can simply open the root folder and the project
should be automatically imported. You will need to configure a Platform SDK that
is JDK 15 or above. Either set this up manually, or [build](#building) once from
is JDK 14 or above. Either set this up manually, or [build](#building) once from
the terminal, which will download a suitable JDK. Configure IntelliJ to use it
at `File → Project Structure → Platform Settings → SDKs → + → Add JDK...` and
browse to the downloaded JDK found in `<skara-folder>/.jdk/`. For example, on
@@ -58,11 +58,8 @@ class CheckRun {
private static final String outdatedHelpMarker = "<!-- PullRequestBot outdated help comment -->";
private static final String sourceBranchWarningMarker = "<!-- PullRequestBot source branch warning comment -->";
private static final String mergeCommitWarningMarker = "<!-- PullRequestBot merge commit warning comment -->";
private static final String emptyPrBodyMarker = """
<!--
Replace this text with a description of your pull request (also remove the surrounding HTML comment markers).
If in doubt, feel free to delete everything in this edit box first, the bot will restore the progress section as needed.
-->""";
private static final String emptyPrBodyMarker = "<!--\nReplace this text with a description of your pull request (also remove the surrounding HTML comment markers).\n" +
"If in doubt, feel free to delete everything in this edit box first, the bot will restore the progress section as needed.\n-->";
private static final String fullNameWarningMarker = "<!-- PullRequestBot full name warning comment -->";
private final static Set<String> primaryTypes = Set.of("Bug", "New Feature", "Enhancement", "Task", "Sub-task");
private final Set<String> newLabels;