Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1102: Document minimum required JDK version 16 for Skara #1195

Closed
wants to merge 3 commits into from

Conversation

erikj79
Copy link
Member

@erikj79 erikj79 commented Jul 7, 2021

Change documentation to reflect that Skara now requires JDK 16 to build.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-1102: Document minimum required JDK version 16 for Skara

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1195/head:pull/1195
$ git checkout pull/1195

Update a local copy of the PR:
$ git checkout pull/1195
$ git pull https://git.openjdk.java.net/skara pull/1195/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1195

View PR using the GUI difftool:
$ git pr show -t 1195

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1195.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 7, 2021

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title SKARA-1102 1102: Document minimum required JDK version 16 for Skara Jul 7, 2021
@openjdk openjdk bot added the rfr label Jul 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 7, 2021

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

You might also want to change the example of openjdk-15.0.1_osx-x64_bin/jdk-15.0.1.jdk to openjdk-16.0.1_osx-x64_bin/jdk-16.0.1.jdk, but otherwise looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 7, 2021

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

1102: Document minimum required JDK version 16 for Skara

Reviewed-by: kcr, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 2540619: 1085: Gitlab PR has bad link to patch file
  • ac074bc: 1095: Ignore tags in pr branches when notifying

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 7, 2021
README.md Show resolved Hide resolved
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 8, 2021

Mailing list message from erik.joelsson at oracle.com on skara-dev:

On 2021-07-07 13:23, Iris Clark wrote:

On Wed, 7 Jul 2021 20:13:23 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

Change documentation to reflect that Skara now requires JDK 16 to build.
Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:

Update example
README.md line 49:

47: ## Building
48:
49: [JDK 16](http://jdk.java.net/16/) or later and [Gradle](https://gradle.org/)
How often is the minimum JDK version for Skara updated? If it's always the last GA'd version of the JDK, perhaps that sort of phrasing should be used instead?

The JDK we use by default is updated quite frequently, but the required
JDK version has not intentionally been kept at the latest. This has been
caused by dependencies creeping in. We can't just blindly update either
as we have to wait for a Gradle version that supports the new JDK
version. I think we should keep it well defined through documentation,
but also make the build use the release flag to force compatibility with
the documented JDK version.

I will see if I can figure out how to change that in Gradle.

/Erik

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 8, 2021

Mailing list message from Iris Clark on skara-dev:

Hi, Erik.

Thanks for the explanation. I can't say that I'm surprised. I agree that the documentation should continue to explicitly declare the version number. I hope you find a solution in Gradle.

Best,
Iris

________________________________
From: erik.joelsson at oracle.com <erik.joelsson at oracle.com>
Sent: Thursday, July 8, 2021 11:57 AM
To: Iris Clark <iris at openjdk.java.net>; skara-dev at openjdk.java.net <skara-dev at openjdk.java.net>
Subject: Re: RFR: 1102: Document minimum required JDK version 16 for Skara [v2]

On 2021-07-07 13:23, Iris Clark wrote:

On Wed, 7 Jul 2021 20:13:23 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

Change documentation to reflect that Skara now requires JDK 16 to build.
Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:

Update example
README.md line 49:

47: ## Building
48:
49: [JDK 16](http://jdk.java.net/16/) or later and [Gradle](https://gradle.org/)
How often is the minimum JDK version for Skara updated? If it's always the last GA'd version of the JDK, perhaps that sort of phrasing should be used instead?

The JDK we use by default is updated quite frequently, but the required
JDK version has not intentionally been kept at the latest. This has been
caused by dependencies creeping in. We can't just blindly update either
as we have to wait for a Gradle version that supports the new JDK
version. I think we should keep it well defined through documentation,
but also make the build use the release flag to force compatibility with
the documented JDK version.

I will see if I can figure out how to change that in Gradle.

/Erik

@erikj79
Copy link
Member Author

@erikj79 erikj79 commented Jul 8, 2021

Added 'release 16' for all Java compilation in Gradle. Verified that setting it to 15 triggered the same compilation errors I saw in Intellij when setting it to 15 there.

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Good idea to set --release 16

@erikj79
Copy link
Member Author

@erikj79 erikj79 commented Jul 9, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2021

Going to push as commit 2ae00f8.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 2540619: 1085: Gitlab PR has bad link to patch file
  • ac074bc: 1095: Ignore tags in pr branches when notifying

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 9, 2021

@erikj79 Pushed as commit 2ae00f8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants