New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1108: Fix label updater for gitlab #1196
Conversation
|
Webrevs
|
Also fixed a log message. |
@erikj79 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
There were indeed. I've now updated the tests for the change I made. |
/integrate |
Going to push as commit 68fc5e4. |
When deploying SKARA-1084 I discovered that gitlab doesn't accept '<' or '>' in label descriptions. The email address toString() method returns the email inside those characters. I don't think we need to store that in the description so simply switch to adding the .address() instead.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1196/head:pull/1196
$ git checkout pull/1196
Update a local copy of the PR:
$ git checkout pull/1196
$ git pull https://git.openjdk.java.net/skara pull/1196/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1196
View PR using the GUI difftool:
$ git pr show -t 1196
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1196.diff