Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1108: Fix label updater for gitlab #1196

Closed
wants to merge 2 commits into from

Conversation

erikj79
Copy link
Member

@erikj79 erikj79 commented Jul 13, 2021

When deploying SKARA-1084 I discovered that gitlab doesn't accept '<' or '>' in label descriptions. The email address toString() method returns the email inside those characters. I don't think we need to store that in the description so simply switch to adding the .address() instead.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1196/head:pull/1196
$ git checkout pull/1196

Update a local copy of the PR:
$ git checkout pull/1196
$ git pull https://git.openjdk.java.net/skara pull/1196/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1196

View PR using the GUI difftool:
$ git pr show -t 1196

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1196.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 13, 2021

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title SKARA-1108 1108: Fix label updater for gitlab Jul 13, 2021
@openjdk openjdk bot added the rfr label Jul 13, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 13, 2021

Webrevs

@erikj79
Copy link
Member Author

@erikj79 erikj79 commented Jul 13, 2021

Also fixed a log message.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

1108: Fix label updater for gitlab

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 13, 2021
Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks like there are failing tests.

@openjdk openjdk bot removed the ready label Jul 13, 2021
@erikj79
Copy link
Member Author

@erikj79 erikj79 commented Jul 13, 2021

Looks like there are failing tests.

There were indeed. I've now updated the tests for the change I made.

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good.

@openjdk openjdk bot added the ready label Jul 13, 2021
@erikj79
Copy link
Member Author

@erikj79 erikj79 commented Jul 13, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

Going to push as commit 68fc5e4.

@openjdk openjdk bot closed this Jul 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

@erikj79 Pushed as commit 68fc5e4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants