Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape quotes in shell code stored in gitconfig. #120

Closed
wants to merge 1 commit into from

Conversation

rose00
Copy link

@rose00 rose00 commented Sep 8, 2019

https://bugs.openjdk.java.net/browse/SKARA-99

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 9, 2019

👋 Welcome back jrose! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Sep 9, 2019
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 9, 2019

Webrevs

edvbld
edvbld approved these changes Sep 9, 2019
Copy link
Member

@edvbld edvbld left a comment

Thanks John for contributing, looks good!

@openjdk openjdk bot removed the rfr label Sep 9, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2019

@rose00 This change can now be integrated. The commit message will be:

Escape quotes in shell code stored in gitconfig.

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • d14976e: Add support for Mercurial

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@edvbld) but any other Committer may sponsor as well.

  • To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 9, 2019
@rose00
Copy link
Author

@rose00 rose00 commented Sep 9, 2019

/integrate

(Hey, where are the /foo commands documented?)

(And, as idle curiosity, should there be a /reviewed command? I note that @edvbld didn't use such a command in his approval comment, but rather must have pushed an invisible button somewhere.)

@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2019

@rose00
Your change (at version e263791) is now ready to be sponsored by a Committer.

@openjdk openjdk bot added the sponsor label Sep 9, 2019
@edvbld
Copy link
Member

@edvbld edvbld commented Sep 10, 2019

@rose00 we haven't really had time to write up all the documentation yet, that is coming on the Skara wiki. As for a "review" command, maybe, but all platforms feature review functionality (plus the Skara CLI tooling also supports git pr approve). On GitHub the actually not so invisible button appears when you click the "Files changed" tab 😸

@edvbld
Copy link
Member

@edvbld edvbld commented Sep 10, 2019

/sponsor

@openjdk openjdk bot closed this Sep 10, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2019

@edvbld @rose00 The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit 96b7146.

@rose00
Copy link
Author

@rose00 rose00 commented Sep 10, 2019

Thanks for the tour!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants