Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

73: Improve email threading, add separate approval email #121

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Sep 9, 2019

Hi all,

Please review this update to the mailing list bridge bot, that improves threading of messages and also adds a separate approval message.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 9, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 9, 2019

Webrevs

edvbld
edvbld approved these changes Sep 10, 2019
Copy link
Member

@edvbld edvbld left a comment

Hmmm, this PR is definitely on the larger side, but I see you have it tested it quite thoroughly, so lets integrate it.

@openjdk openjdk bot removed the rfr label Sep 10, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2019

@rwestberg This change can now be integrated. The commit message will be:

73: Improve email threading, add separate approval email

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • 96b7146: Escape quotes in shell code stored in gitconfig.
  • d14976e: Add support for Mercurial

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 10, 2019
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Sep 10, 2019

/integrate

@openjdk openjdk bot closed this Sep 10, 2019
@openjdk openjdk bot added the integrated label Sep 10, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit 39c5189.

@openjdk openjdk bot removed the ready label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants