Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1125: OpenJDK 7 backports incorrectly tagged with hgupdate-sync #1215

Closed

Conversation

erikj79
Copy link
Member

@erikj79 erikj79 commented Sep 3, 2021

This patch makes "openjdk7u" a valid JdkVersion in the Skara version parser. This was preventing the SyncLabelBot from properly setting or removing the hgupdate-sync label on backports with this fixVersion.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-1125: OpenJDK 7 backports incorrectly tagged with hgupdate-sync

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1215/head:pull/1215
$ git checkout pull/1215

Update a local copy of the PR:
$ git checkout pull/1215
$ git pull https://git.openjdk.java.net/skara pull/1215/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1215

View PR using the GUI difftool:
$ git pr show -t 1215

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1215.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 3, 2021

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title SKARA-1125 1125: OpenJDK 7 backports incorrectly tagged with hgupdate-sync Sep 3, 2021
@openjdk openjdk bot added the rfr label Sep 3, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 3, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 3, 2021

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

1125: OpenJDK 7 backports incorrectly tagged with hgupdate-sync

Reviewed-by: kcr, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 3, 2021
magicus
magicus approved these changes Sep 6, 2021
@erikj79
Copy link
Member Author

erikj79 commented Sep 7, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Sep 7, 2021

Going to push as commit 34c565e.

@openjdk openjdk bot closed this Sep 7, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 7, 2021
@openjdk
Copy link

openjdk bot commented Sep 7, 2021

@erikj79 Pushed as commit 34c565e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants