New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1150: Migrate skara tooling for client code to reference the new client-libs-dev list #1216
Conversation
|
Webrevs
|
@prrace should take a look at this. It can probably be optimized further if we assume that everything under With that assumption, I think this would be the minimal reduction:
And then you would probably add the 3 beans files that formerly had the |
Phil doesn't understand why beans is still separate. In the JBS I wrote So beans-dev is going away too .. so the entire java.desktop module should be mapped to client-libs-dev You may also find it useful to look at what I put here : https://openjdk.java.net/groups/client-libs/ It enumerates all the source, demo, test, make/build files I could identify that are handled by client-libs |
Thanks for the input Phil and Kevin, I missed that beans was also included. I will simplify this further. |
@erikj79 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
/integrate |
Going to push as commit e398e44. |
Here is my attempt at trying to rewrite the rules for automatic labeling for the new "client" label and client-libs-dev mailing list. I took the combined contents of the previous 2d, awt, sound and swing labels, sorted the lines and then tried to manually merge as much as possible. It's possible I didn't get everything correct or at least not fully optimized.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1216/head:pull/1216
$ git checkout pull/1216
Update a local copy of the PR:
$ git checkout pull/1216
$ git pull https://git.openjdk.java.net/skara pull/1216/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1216
View PR using the GUI difftool:
$ git pr show -t 1216
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1216.diff