Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1167: Update the mapping of files for the client group #1217

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -12,17 +12,21 @@
],
"client": [
"make/\\w+(Demos|X11)",
"make/autoconf/lib-(font|freetype|x11)",
"make/autoconf/lib-(alsa|cups|font|freetype|x11)",
Copy link
Member Author

@mrserb mrserb Sep 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it fine in a few places to use the "font" instead of "fontconfig" and "x11" instead of "x11wrappergen"?

Copy link
Member

@erikj79 erikj79 Sep 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that the regexp is used to match a prefix. If you add a slash at the end, you enforce a full directory name instead of a partial match. Feel free to rewrite as you like.

"make/data/(font|x11)",
"make/jdk/src/classes/build/tools/(generatenimbus/|x11wrappergen)",
"make/jdk/src/classes/build/tools/(generatenimbus|x11wrappergen)",
"make/modules/java.desktop/",
"make/modules/java.datatransfer/",
"make/modules/jdk.accessibility/",
"make/modules/jdk.unsupported.desktop/",
"src/demo/",
"src/java.base/share/classes/jdk/internal/access/\\w+AWT",
"src/java.datatransfer/",
"src/java.desktop/",
"src/jdk.accessibility/",
"src/jdk.unsupported.desktop/",
"test/jdk/com/apple/laf/ScreenMenu",
"test/jdk/com/apple/laf/",
"test/jdk/com/apple/eawt/",
"test/jdk/com/sun/java/",
"test/jdk/demo/jfc/",
"test/jdk/java/awt/",
@@ -32,6 +36,8 @@
"test/jdk/javax/print/",
"test/jdk/javax/sound/",
"test/jdk/javax/swing/",
"test/jdk/lib/client/",
"test/jdk/performance/client/",
"test/jdk/sanity/client/",
"test/jdk/sun/awt/",
"test/jdk/sun/java2d/"