Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1170: Notify bot reposts commit comments if another notifier fails #1218

Closed

Conversation

erikj79
Copy link
Member

@erikj79 erikj79 commented Sep 13, 2021

Prevent the CommitCommentNotifier from posting the exact same comment twice.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-1170: Notify bot reposts commit comments if another notifier fails

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1218/head:pull/1218
$ git checkout pull/1218

Update a local copy of the PR:
$ git checkout pull/1218
$ git pull https://git.openjdk.java.net/skara pull/1218/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1218

View PR using the GUI difftool:
$ git pr show -t 1218

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1218.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 13, 2021

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title SKARA-1170 1170: Notify bot reposts commit comments if another notifier fails Sep 13, 2021
@openjdk openjdk bot added the rfr label Sep 13, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 13, 2021

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 13, 2021

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

1170: Notify bot reposts commit comments if another notifier fails

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • d816d14: 1167: Update the mapping of files for the client group
  • e398e44: 1150: Migrate skara tooling for client code to reference the new client-libs-dev list

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 13, 2021
@erikj79
Copy link
Member Author

@erikj79 erikj79 commented Sep 13, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 13, 2021

Going to push as commit a6c854a.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 57944f6: Better logging in mlbridge
  • d816d14: 1167: Update the mapping of files for the client group
  • e398e44: 1150: Migrate skara tooling for client code to reference the new client-libs-dev list

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 13, 2021
@openjdk openjdk bot added integrated and removed ready labels Sep 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 13, 2021

@erikj79 Pushed as commit a6c854a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants