1180: Improve logging when WorkItems run for too long #1222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When trying to investigate SKARA-1178, I was finding myself lacking vital information in the logs. Specifically I wanted to know which WorkItem instances in particular (workId) that were running for too long, and also how long they had actually been running. (The current calculation will always just show the timeout value.)
This patch changes things around a bit in the BotRunner to make these values available when logging a timeout warning.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1222/head:pull/1222
$ git checkout pull/1222
Update a local copy of the PR:
$ git checkout pull/1222
$ git pull https://git.openjdk.java.net/skara pull/1222/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1222
View PR using the GUI difftool:
$ git pr show -t 1222
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1222.diff