1180: Improve logging when WorkItems run for too long

[erikj79]

When trying to investigate SKARA-1178, I was finding myself lacking vital information in the logs. Specifically I wanted to know which WorkItem instances in particular (workId) that were running for too long, and also how long they had actually been running. (The current calculation will always just show the timeout value.)

This patch changes things around a bit in the BotRunner to make these values available when logging a timeout warning.

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Issue

• SKARA-1180: Improve logging when WorkItems run for too long

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1222/head:pull/1222
$ git checkout pull/1222

Update a local copy of the PR:
$ git checkout pull/1222
$ git pull https://git.openjdk.java.net/skara pull/1222/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1222

View PR using the GUI difftool:
$ git pr show -t 1222

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1222.diff

[bridgekeeper]

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (21970923)

[openjdk]

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

1180: Improve logging when WorkItems run for too long

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[erikj79]

/integrate

[openjdk]

Going to push as commit 03e8d58.

[openjdk]

@erikj79 Pushed as commit 03e8d58.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.