Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1197: Label changes from java.nio.** as nio #1225

Closed
wants to merge 1 commit into from

Conversation

pavelrappo
Copy link
Member

@pavelrappo pavelrappo commented Sep 30, 2021

Please review this PR which adds a mailing list rule for New I/O (NIO). The change was tested as per https://mail.openjdk.java.net/pipermail/jdk-dev/2020-August/004662.html


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-1197: Label changes from java.nio.** as nio

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1225/head:pull/1225
$ git checkout pull/1225

Update a local copy of the PR:
$ git checkout pull/1225
$ git pull https://git.openjdk.java.net/skara pull/1225/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1225

View PR using the GUI difftool:
$ git pr show -t 1225

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1225.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 30, 2021

👋 Welcome back prappo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@pavelrappo pavelrappo changed the title Initial commit 1197: Label changes from java.nio.** as nio Sep 30, 2021
@openjdk openjdk bot added the rfr label Sep 30, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 30, 2021

Webrevs

Copy link
Member

@magicus magicus left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Sep 30, 2021

@pavelrappo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

1197: Label changes from java.nio.** as nio

Reviewed-by: ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 68872aa: 1194: Implement git webrev --no-comments option

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@magicus) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 30, 2021
@pavelrappo
Copy link
Member Author

@pavelrappo pavelrappo commented Sep 30, 2021

/integrate

@openjdk openjdk bot added the sponsor label Sep 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 30, 2021

@pavelrappo
Your change (at version 5fe0e16) is now ready to be sponsored by a Committer.

@magicus
Copy link
Member

@magicus magicus commented Sep 30, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Sep 30, 2021

Going to push as commit acda266.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 68872aa: 1194: Implement git webrev --no-comments option

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 30, 2021

@magicus @pavelrappo Pushed as commit acda266.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants