New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add markdown filtering #123
Conversation
|
Webrevs
|
Looks good, I've been longing for some unicode in my source files
@rwestberg This change can now be integrated. The commit message will be:
|
Didn't intend for the approval messages to be collapsed though, guess it needs a bit more polishing. |
@@ -119,7 +119,7 @@ private Email parentForReviewComment(ReviewComment reviewComment) { | |||
.max(Comparator.comparingInt(email -> Integer.parseInt(email.headerValue("PR-Sequence")))); | |||
|
|||
if (last.isEmpty()) { | |||
throw new RuntimeException("Failed to find parent"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well fix this one at the same time.
@@ -119,7 +119,7 @@ private Email parentForReviewComment(ReviewComment reviewComment) { | |||
.max(Comparator.comparingInt(email -> Integer.parseInt(email.headerValue("PR-Sequence")))); | |||
|
|||
if (last.isEmpty()) { | |||
throw new RuntimeException("Failed to find parent"); | |||
throw new RuntimeException("Failed to find parent"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this is just a comment to trigger Robin's new mailing list bridge.
/integrate |
@rwestberg Pushed as commit e54f813. |
Hi all,
Please review this change that adds basic markdown filtering when forwarding hosted comments to mailing lists. This is far from a proper CommonMark parser, but should improve the readability of forwarded comments.
Best regards,
Robin
Progress
Approvers