Add markdown filtering #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Webrevs
|
|
@rwestberg This change can now be integrated. The commit message will be:
|
|
Didn't intend for the approval messages to be collapsed though, guess it needs a bit more polishing. |
rwestberg
reviewed
Sep 10, 2019
| @@ -119,7 +119,7 @@ private Email parentForReviewComment(ReviewComment reviewComment) { | |||
| .max(Comparator.comparingInt(email -> Integer.parseInt(email.headerValue("PR-Sequence")))); | |||
|
|
|||
| if (last.isEmpty()) { | |||
| throw new RuntimeException("Failed to find parent"); | |||
There was a problem hiding this comment.
Might as well fix this one at the same time.
edvbld
reviewed
Sep 10, 2019
| @@ -119,7 +119,7 @@ private Email parentForReviewComment(ReviewComment reviewComment) { | |||
| .max(Comparator.comparingInt(email -> Integer.parseInt(email.headerValue("PR-Sequence")))); | |||
|
|
|||
| if (last.isEmpty()) { | |||
| throw new RuntimeException("Failed to find parent"); | |||
| throw new RuntimeException("Failed to find parent"); | |||
There was a problem hiding this comment.
Note: this is just a comment to trigger Robin's new mailing list bridge.
|
/integrate |
|
@rwestberg Pushed as commit e54f813. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hi all,
Please review this change that adds basic markdown filtering when forwarding hosted comments to mailing lists. This is far from a proper CommonMark parser, but should improve the readability of forwarded comments.
Best regards,
Robin
Progress
Approvers