Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd markdown filtering #123
Closed
Conversation
bridgekeeper
bot
commented
Sep 10, 2019
|
|
mlbridge
bot
commented
Sep 10, 2019
•
Webrevs
|
|
Looks good, I've been longing for some unicode in my source files |
openjdk
bot
commented
Sep 10, 2019
|
@rwestberg This change can now be integrated. The commit message will be:
|
|
Didn't intend for the approval messages to be collapsed though, guess it needs a bit more polishing. |
| @@ -119,7 +119,7 @@ private Email parentForReviewComment(ReviewComment reviewComment) { | |||
| .max(Comparator.comparingInt(email -> Integer.parseInt(email.headerValue("PR-Sequence")))); | |||
|
|
|||
| if (last.isEmpty()) { | |||
| throw new RuntimeException("Failed to find parent"); | |||
This comment has been minimized.
This comment has been minimized.
| @@ -119,7 +119,7 @@ private Email parentForReviewComment(ReviewComment reviewComment) { | |||
| .max(Comparator.comparingInt(email -> Integer.parseInt(email.headerValue("PR-Sequence")))); | |||
|
|
|||
| if (last.isEmpty()) { | |||
| throw new RuntimeException("Failed to find parent"); | |||
| throw new RuntimeException("Failed to find parent"); | |||
This comment has been minimized.
This comment has been minimized.
|
/integrate |
openjdk
bot
commented
Sep 11, 2019
|
@rwestberg Pushed as commit e54f813. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
rwestberg commentedSep 10, 2019
•
edited by openjdk bot
Hi all,
Please review this change that adds basic markdown filtering when forwarding hosted comments to mailing lists. This is far from a proper CommonMark parser, but should improve the readability of forwarded comments.
Best regards,
Robin
Progress
Approvers