Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown filtering #123

Closed
wants to merge 2 commits into from
Closed

Conversation

@rwestberg
Copy link
Member

rwestberg commented Sep 10, 2019

Hi all,

Please review this change that adds basic markdown filtering when forwarding hosted comments to mailing lists. This is far from a proper CommonMark parser, but should improve the readability of forwarded comments.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 10, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added rfr bots labels Sep 10, 2019
@mlbridge
Copy link

mlbridge bot commented Sep 10, 2019

Webrevs

@edvbld
edvbld approved these changes Sep 10, 2019
Copy link
Member

edvbld left a comment

Looks good, I've been longing for some unicode in my source files 😄

@openjdk openjdk bot removed the rfr label Sep 10, 2019
@openjdk
Copy link

openjdk bot commented Sep 10, 2019

@rwestberg This change can now be integrated. The commit message will be:

Add markdown filtering

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Sep 10, 2019
@rwestberg
Copy link
Member Author

rwestberg commented Sep 10, 2019

Didn't intend for the approval messages to be collapsed though, guess it needs a bit more polishing.

@@ -119,7 +119,7 @@ private Email parentForReviewComment(ReviewComment reviewComment) {
.max(Comparator.comparingInt(email -> Integer.parseInt(email.headerValue("PR-Sequence"))));

if (last.isEmpty()) {
throw new RuntimeException("Failed to find parent");

This comment has been minimized.

@rwestberg

rwestberg Sep 10, 2019 Author Member

Might as well fix this one at the same time.

@@ -119,7 +119,7 @@ private Email parentForReviewComment(ReviewComment reviewComment) {
.max(Comparator.comparingInt(email -> Integer.parseInt(email.headerValue("PR-Sequence"))));

if (last.isEmpty()) {
throw new RuntimeException("Failed to find parent");
throw new RuntimeException("Failed to find parent");

This comment has been minimized.

@edvbld

edvbld Sep 10, 2019 Member

Note: this is just a comment to trigger Robin's new mailing list bridge.

@rwestberg
Copy link
Member Author

rwestberg commented Sep 11, 2019

/integrate

@openjdk openjdk bot closed this Sep 11, 2019
@openjdk openjdk bot added integrated and removed ready labels Sep 11, 2019
@openjdk
Copy link

openjdk bot commented Sep 11, 2019

@rwestberg Pushed as commit e54f813.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.