Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Mercurial compatability #125

Closed
wants to merge 1 commit into from
Closed

Better Mercurial compatability #125

wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Sep 11, 2019

Hi all,

this patch improves the Mercurial (hg) support for git fork and git pr. Now all subcommands work with hg pr except for hg pr create which I haven't fixed yet.

Testing

  • sh gradlew test passes on Linux x86_64
  • Manual testing of hg pr, hg fork, hg webrev and hg jcheck

Thanks,
Erik

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 11, 2019

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 11, 2019

Webrevs

@openjdk openjdk bot removed the rfr label Sep 11, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Sep 11, 2019

@edvbld This change can now be integrated. The commit message will be:

Better Mercurial compatability

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch:

  • e54f813: Add markdown filtering
  • 39c5189: 73: Improve email threading, add separate approval email
  • 96b7146: Escape quotes in shell code stored in gitconfig.

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 11, 2019
@edvbld
Copy link
Member Author

@edvbld edvbld commented Sep 11, 2019

/integrate

@openjdk openjdk bot closed this Sep 11, 2019
@openjdk openjdk bot added integrated and removed ready labels Sep 11, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Sep 11, 2019

@edvbld The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit 81c6aae.

@edvbld edvbld deleted the more-hg branch Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants