Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

713: Rename git/pr-approve to git-pr-review #1256

Closed
wants to merge 1 commit into from

Conversation

@lgxbslgx
Copy link
Member

@lgxbslgx lgxbslgx commented Dec 8, 2021

Hi all,

This patch changes the command git pr approve to git pr review and adds the option type to identify the review type approve, request-changes or comment.

I tested this patch in PR1 mistakenly. Apology for the wrong operation. And I can't find the right place to test the git pr command now.

Thanks for taking the time to review.

Best Regards,
-- Guoxiong


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-713: Rename git/pr-approve to git-pr-review

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1256/head:pull/1256
$ git checkout pull/1256

Update a local copy of the PR:
$ git checkout pull/1256
$ git pull https://git.openjdk.java.net/skara pull/1256/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1256

View PR using the GUI difftool:
$ git pr show -t 1256

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1256.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 8, 2021

👋 Welcome back gli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 8, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 8, 2021

Webrevs

@erikj79
Copy link
Member

@erikj79 erikj79 commented Dec 8, 2021

I recommend using the repository https://github.com/openjdk/playground to test your changes. You can create PRs and play around there freely.

@lgxbslgx
Copy link
Member Author

@lgxbslgx lgxbslgx commented Dec 8, 2021

I recommend using the repository https://github.com/openjdk/playground to test your changes. You can create PRs and play around there freely.

Thanks for the advising.

erikj79
erikj79 approved these changes Dec 9, 2021
Copy link
Member

@erikj79 erikj79 left a comment

If you think you have tested this enough, then the change looks good to me.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 9, 2021

@lgxbslgx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

713: Rename git/pr-approve to git-pr-review

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 57c88f5: 1269: Handle Jira host with path element in URL
  • bfc39d9: 1270: Allow different 'issues' urls for different repositories in mlbridge configuration

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Dec 9, 2021
@lgxbslgx
Copy link
Member Author

@lgxbslgx lgxbslgx commented Dec 9, 2021

@erikj79 Thanks for the review. Could I get your help to sponsor this patch?

/integrate

@openjdk openjdk bot added the sponsor label Dec 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 9, 2021

@lgxbslgx
Your change (at version a223b28) is now ready to be sponsored by a Committer.

@lgxbslgx
Copy link
Member Author

@lgxbslgx lgxbslgx commented Dec 15, 2021

Could I get your help to sponsor this patch? Thanks a lot.

@erikj79
Copy link
Member

@erikj79 erikj79 commented Dec 15, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Dec 15, 2021

Going to push as commit 1b06b94.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 68394f5: 1283: Test failures with Mercurial 6.0
  • 3caed6e: 1281: Jcheck fails to run due to IllegalStateException
  • 2ed56ac: 1280: Possible race condition when integrating PR could cause a spurious "Withdrawn" email
  • 57c88f5: 1269: Handle Jira host with path element in URL
  • bfc39d9: 1270: Allow different 'issues' urls for different repositories in mlbridge configuration

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 15, 2021

@erikj79 @lgxbslgx Pushed as commit 1b06b94.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lgxbslgx lgxbslgx deleted the SKARA-713 branch Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants