Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out PR-headers before sending mails #133

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Sep 17, 2019

Hi all,

Please review this change that removes the "internal" PR-headers used by the mailinglist bridge to keep track of certain metadata. This data is used within the internal archives, but does not need to be sent out to actual mailinglists.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 17, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 17, 2019

Webrevs

edvbld
edvbld approved these changes Sep 17, 2019
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Sep 17, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2019

@rwestberg This change can now be integrated. The commit message will be:

Filter out PR-headers before sending mails

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 17, 2019
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Sep 17, 2019

/integrate

@openjdk openjdk bot closed this Sep 17, 2019
@openjdk openjdk bot added integrated and removed ready labels Sep 17, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2019

@rwestberg Pushed as commit cd61be8.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 17, 2019

Mailing list message from duke duke@openjdk.java.net

Changeset: cd61be8
Author: Robin Westberg
Date: 2019-09-17 10:49:22 +0000
URL: https://git.openjdk.java.net/skara/commit/cd61be82

Filter out PR-headers before sending mails

Reviewed-by: ehelin

! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ReviewArchive.java
! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java
! email/src/main/java/org/openjdk/skara/email/EmailBuilder.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants