Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid quoting footers #134

Closed
wants to merge 1 commit into from
Closed

Avoid quoting footers #134

wants to merge 1 commit into from

Conversation

@rwestberg
Copy link
Member

rwestberg commented Sep 17, 2019

Hi all,

Please review this small change that avoids including the PR link in footers when quoting parent posts.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 17, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added rfr bots labels Sep 17, 2019
@mlbridge
Copy link

mlbridge bot commented Sep 17, 2019

Webrevs

@edvbld
edvbld approved these changes Sep 17, 2019
Copy link
Member

edvbld left a comment

Ah, very nice enhancement, looks good!

@openjdk openjdk bot removed the rfr label Sep 17, 2019
@openjdk
Copy link

openjdk bot commented Sep 17, 2019

@rwestberg This change can now be integrated. The commit message will be:

Avoid quoting footers

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • cd61be8: Filter out PR-headers before sending mails

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Sep 17, 2019
@rwestberg
Copy link
Member Author

rwestberg commented Sep 17, 2019

/integrate

@openjdk openjdk bot closed this Sep 17, 2019
@openjdk openjdk bot added the integrated label Sep 17, 2019
@openjdk
Copy link

openjdk bot commented Sep 17, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit f7d6f00.

@openjdk openjdk bot removed the ready label Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.