Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thumbs up emoji alias #135

Closed
wants to merge 1 commit into from
Closed

Add thumbs up emoji alias #135

wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Sep 17, 2019

Hi all,

Please review this minor change that adds an entry for the 馃憤 emoji, which we've recently encountered in the wild.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 17, 2019

馃憢 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 17, 2019

Webrevs

edvbld
edvbld approved these changes Sep 17, 2019
Copy link
Member

@edvbld edvbld left a comment

Haha, yes, I like the "thumbs up" emoji. Nice patch, looks good 馃憤

@openjdk openjdk bot removed the rfr label Sep 17, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2019

@rwestberg This change can now be integrated. The commit message will be:

Add thumbs up emoji alias

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • f7d6f00: Avoid quoting footers
  • cd61be8: Filter out PR-headers before sending mails

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 17, 2019
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Sep 17, 2019

/integrate

@openjdk openjdk bot closed this Sep 17, 2019
@openjdk openjdk bot added the integrated label Sep 17, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit 2c1e9ac.

@openjdk openjdk bot removed the ready label Sep 17, 2019
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 17, 2019

Mailing list message from duke duke@openjdk.java.net

Changeset: 2c1e9ac
Author: Robin Westberg
Date: 2019-09-17 12:11:21 +0000
URL: https://git.openjdk.java.net/skara/commit/2c1e9ac8

Add thumbs up emoji alias

Reviewed-by: ehelin

! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/EmojiTable.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants