New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put the credentials lock in the remote repository #14
Conversation
…rted from multiple hosts
|
Webrevs
|
Repository localRepo; | ||
localRepo = Repository.materialize(repoFolder, repo.getUrl(), "testlock"); | ||
localRepo.remove(lockFile); | ||
var lockHash = localRepo.commit("Lock", "test", "test@test.test"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the commit message comment to "Unlock" to help future debugging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point
This PR has been reviewed by Robin Westberg (rwestberg - Reviewer) - comment added. |
This PR has been reviewed by Erik Helin (ehelin - Reviewer) - comment added. |
The PR review by Erik Helin (ehelin - Reviewer) has been updated - changes are approved. |
@rwestberg This change can now be integrated. The commit message will be:
Since the source branch of this PR was last updated there have been 2 commits pushed to the
Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge
|
/integrate |
@rwestberg The following commits have been pushed to master since your change was applied: Your commit was automatically rebased without conflicts. |
Hi all,
Please review the following change that puts the credentials lock (used when running integration tests) in the remote repository instead of a local file, to allow the tests to be launched from multiple hosts.
Best regards,
Robin
Progress
Approvers