Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put the credentials lock in the remote repository #14

Closed
wants to merge 2 commits into from
Closed

Put the credentials lock in the remote repository #14

wants to merge 2 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Jul 1, 2019 •
edited by openjdk[bot] bot

Hi all,

Please review the following change that puts the credentials lock (used when running integration tests) in the remote repository instead of a local file, to allow the tests to be launched from multiple hosts.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 1, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 1, 2019 •
edited

Webrevs

edvbld
edvbld reviewed Jul 1, 2019
View changes
test/src/main/java/org/openjdk/skara/test/HostCredentials.java Show resolved Hide resolved
test/src/main/java/org/openjdk/skara/test/HostCredentials.java Outdated
Repository localRepo;
localRepo = Repository.materialize(repoFolder, repo.getUrl(), "testlock");
localRepo.remove(lockFile);
var lockHash = localRepo.commit("Lock", "test", "test@test.test");
Copy link
Member

@edvbld edvbld Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message comment to "Unlock" to help future debugging

Copy link
Member Author

@rwestberg rwestberg Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2019

This PR has been reviewed by Robin Westberg (rwestberg - Reviewer) - comment added.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2019

This PR has been reviewed by Erik Helin (ehelin - Reviewer) - comment added.

edvbld
edvbld approved these changes Jul 1, 2019
View changes
Copy link
Member

@edvbld edvbld left a comment

Thanks, looks good!

@openjdk openjdk bot removed the rfr label Jul 1, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2019

The PR review by Erik Helin (ehelin - Reviewer) has been updated - changes are approved.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2019 •
edited

@rwestberg This change can now be integrated. The commit message will be:

Put the credentials lock in the remote repository

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • 728cfa1: 32: GitRepository::show does not work with executable files
  • 3565522: 17: Review comments not reflected on mailing lists

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 1, 2019
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Jul 1, 2019

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit c704f49.

@openjdk openjdk bot closed this Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edvbld edvbld

Assignees
No one assigned
Labels
build ready
Milestone
No milestone
2 participants
@rwestberg @edvbld