Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop throwing when unable to find a matching PR #142

Closed
wants to merge 1 commit into from

Conversation

@rwestberg
Copy link
Member

rwestberg commented Sep 18, 2019

Hi all,

Please review this change that stops throwing an exception when failing to match a change to an existing PR in the PR-only mode, as this is not very useful.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 18, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added rfr bots labels Sep 18, 2019
@mlbridge
Copy link

mlbridge bot commented Sep 18, 2019

Webrevs

@edvbld
edvbld approved these changes Sep 18, 2019
Copy link
Member

edvbld left a comment

Thanks for fixing, looks good!

@openjdk openjdk bot removed the rfr label Sep 18, 2019
@openjdk
Copy link

openjdk bot commented Sep 18, 2019

@rwestberg This change can now be integrated. The commit message will be:

Stop throwing when unable to find a matching PR

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Sep 18, 2019
@rwestberg
Copy link
Member Author

rwestberg commented Sep 18, 2019

/integrate

@openjdk openjdk bot closed this Sep 18, 2019
@openjdk openjdk bot added the integrated label Sep 18, 2019
@openjdk
Copy link

openjdk bot commented Sep 18, 2019

@rwestberg Pushed as commit 710b796.

@openjdk openjdk bot removed the ready label Sep 18, 2019
@mlbridge
Copy link

mlbridge bot commented Sep 18, 2019

Mailing list message from duke duke@openjdk.java.net

Changeset: 710b796
Author: Robin Westberg
Date: 2019-09-18 11:53:49 +0000
URL: https://git.openjdk.java.net/skara/commit/710b796e

Stop throwing when unable to find a matching PR

Reviewed-by: ehelin

! bots/notify/src/main/java/org/openjdk/skara/bots/notify/MailingListUpdater.java
! bots/notify/src/test/java/org/openjdk/skara/bots/notify/UpdaterTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.