Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for adding an issue when formatting the commit message #148

Closed
wants to merge 1 commit into from

Conversation

@rwestberg
Copy link
Member

rwestberg commented Sep 19, 2019

Hi all,

Please review this change that allows setting the issue of a commit through the PR title.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)
@bridgekeeper

This comment has been minimized.

Copy link

bridgekeeper bot commented Sep 19, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added rfr bots labels Sep 19, 2019
@mlbridge

This comment has been minimized.

Copy link

mlbridge bot commented Sep 19, 2019

Webrevs

Copy link
Member

edvbld left a comment

Looks good overall, just two minor comments inline.

@@ -212,6 +212,11 @@ public String getTitle() {
return json.get("title").asString();
}

@Override
public void setTitle(String title) {
throw new RuntimeException("not implemented yet");

This comment has been minimized.

Copy link
@edvbld

edvbld Sep 19, 2019

Member

Won't this be an issue if we run the unit tests as integration tests against real hosts?

This comment has been minimized.

Copy link
@rwestberg

rwestberg Sep 20, 2019

Author Member

You are quite right, I was planning to save it for another task, as there are already existing issues with the real host tests..

This comment has been minimized.

Copy link
@edvbld

edvbld Sep 20, 2019

Member

Ah ok, lets tackle it later then 👍

@@ -254,6 +254,11 @@ public String getTitle() {
return json.get("title").asString();
}

@Override
public void setTitle(String title) {
throw new RuntimeException("not implemented yet");

This comment has been minimized.

Copy link
@edvbld

edvbld Sep 19, 2019

Member

Same issue here?

@edvbld
edvbld approved these changes Sep 20, 2019
@openjdk openjdk bot removed the rfr label Sep 20, 2019
@openjdk

This comment has been minimized.

Copy link

openjdk bot commented Sep 20, 2019

@rwestberg This change can now be integrated. The commit message will be:

Add support for adding an issue when formatting the commit message

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch:

  • 915f209: A generated webrev should always include index.html
  • 9e02b45: Fix problem with finding a collapsed parent
  • 1721a19: Handle binary patches in webrev

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Sep 20, 2019
@rwestberg

This comment has been minimized.

Copy link
Member Author

rwestberg commented Sep 23, 2019

/integrate

@openjdk openjdk bot closed this Sep 23, 2019
@openjdk openjdk bot added integrated and removed ready labels Sep 23, 2019
@openjdk

This comment has been minimized.

Copy link

openjdk bot commented Sep 23, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit 0132f0e.

@mlbridge

This comment has been minimized.

Copy link

mlbridge bot commented Sep 23, 2019

Mailing list message from duke duke@openjdk.java.net

Changeset: 0132f0e
Author: Robin Westberg
Date: 2019-09-23 12:57:02 +0000
URL: https://git.openjdk.java.net/skara/commit/0132f0e3

Add support for adding an issue when formatting the commit message

Reviewed-by: ehelin

! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java
! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestInstance.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java
! host/src/main/java/org/openjdk/skara/host/PullRequest.java
! host/src/main/java/org/openjdk/skara/host/github/GitHubPullRequest.java
! host/src/main/java/org/openjdk/skara/host/gitlab/GitLabMergeRequest.java
! test/src/main/java/org/openjdk/skara/test/CheckableRepository.java
! test/src/main/java/org/openjdk/skara/test/TestPullRequest.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.