Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an issue link to RFR mails if the PR title contains one #149

Closed
wants to merge 1 commit into from

Conversation

@rwestberg
Copy link
Member

rwestberg commented Sep 20, 2019

Hi all,

Please review this change that adds an issue link to RFR emails if the PR title contains one. It also allows projects to specify their issue key in case it is different from the project name.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)
  • Kevin Rushforth (kcr - no project role)
@bridgekeeper

This comment has been minimized.

Copy link

bridgekeeper bot commented Sep 20, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added rfr bots labels Sep 20, 2019
@mlbridge

This comment has been minimized.

Copy link

mlbridge bot commented Sep 20, 2019

Webrevs

@edvbld
edvbld approved these changes Sep 20, 2019
Copy link
Member

edvbld left a comment

Looks good, nice work Robin!

@openjdk openjdk bot removed the rfr label Sep 20, 2019
@openjdk

This comment has been minimized.

Copy link

openjdk bot commented Sep 20, 2019

@rwestberg This change can now be integrated. The commit message will be:

Add an issue link to RFR mails if the PR title contains one

Reviewed-by: ehelin, kcr
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 4 commits pushed to the master branch:

  • 0132f0e: Add support for adding an issue when formatting the commit message
  • 915f209: A generated webrev should always include index.html
  • 9e02b45: Fix problem with finding a collapsed parent
  • 1721a19: Handle binary patches in webrev

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Sep 20, 2019
@kevinrushforth

This comment has been minimized.

Copy link
Member

kevinrushforth commented Sep 20, 2019

This looks great. As a follow-on to this, what about having the bot add the JBS URL as a comment in the PR (maybe as part of the status block along with Progress and Approvers)?

@edvbld

This comment has been minimized.

Copy link
Member

edvbld commented Sep 20, 2019

@kevinrushforth it is coming, we are just starting out small 😄

@kevinrushforth

This comment has been minimized.

Copy link
Member

kevinrushforth commented Sep 20, 2019

I'm looking forward to testing this for openjfx, which does have a different JBS prefix than the project name, so I'll be using the jbs field in .jcheck/conf.

Copy link
Member

kevinrushforth left a comment

Looks good to me.

@rwestberg

This comment has been minimized.

Copy link
Member Author

rwestberg commented Sep 23, 2019

/integrate

@openjdk openjdk bot closed this Sep 23, 2019
@openjdk openjdk bot added the integrated label Sep 23, 2019
@openjdk

This comment has been minimized.

Copy link

openjdk bot commented Sep 23, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit cc79727.

@openjdk openjdk bot removed the ready label Sep 23, 2019
@mlbridge

This comment has been minimized.

Copy link

mlbridge bot commented Sep 23, 2019

Mailing list message from duke duke@openjdk.java.net

Changeset: cc79727
Author: Robin Westberg
Date: 2019-09-23 12:57:43 +0000
URL: https://git.openjdk.java.net/skara/commit/cc79727a

Add an issue link to RFR mails if the PR title contains one

Reviewed-by: ehelin, kcr

! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveMessages.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBot.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotFactory.java
! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/PullRequestInstance.java
! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListArchiveReaderBotTests.java
! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/MailingListBridgeBotTests.java
! bots/mlbridge/src/test/java/org/openjdk/skara/bots/mlbridge/WebrevStorageTests.java
! jcheck/src/main/java/org/openjdk/skara/jcheck/GeneralConfiguration.java
! jcheck/src/main/java/org/openjdk/skara/jcheck/JCheckConfiguration.java
! test/src/main/java/org/openjdk/skara/test/CheckableRepository.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.