Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A generated webrev should always include index.html #151

wants to merge 1 commit into from
Changes from all commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.


Just for now

@@ -62,9 +62,13 @@ private void push(Repository localStorage, Path webrevFolder, String identifier)
// Try to push 1000 files at a time
var batches = files.filter(Files::isRegularFile)
.filter(file -> {
// Huge files are not that useful in a webrev
// Huge files are not that useful in a webrev - but make an exception for the index
try {
return Files.size(file) < 1000 * 1000;
if (file.getFileName().toString().equals("index.html")) {
return true;
} else {
return Files.size(file) < 1000 * 1000;
} catch (IOException e) {
return false;
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.