Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

102: Setting summary does not update the preview message #157

Closed
wants to merge 1 commit into from

Conversation

@rwestberg
Copy link
Member

rwestberg commented Sep 23, 2019

Hi all,

Please review this change that ensures that the commit preview message is updated when a summary is added or updated.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Kevin Rushforth (kcr - no project role)
  • Erik Helin (ehelin - Reviewer)
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 23, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added rfr bots labels Sep 23, 2019
@mlbridge
Copy link

mlbridge bot commented Sep 23, 2019

Webrevs

Copy link
Member

kevinrushforth left a comment

Looks good to me.

@edvbld
edvbld approved these changes Sep 24, 2019
Copy link
Member

edvbld left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Sep 24, 2019
@openjdk
Copy link

openjdk bot commented Sep 24, 2019

@rwestberg This change can now be integrated. The commit message will be:

102: Setting summary does not update the preview message

Reviewed-by: kcr, ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 7 commits pushed to the master branch:

  • 7bdfab4: Add "binary" jcheck check
  • 15376a9: Add support for adding extra headers to mails sent to mailing lists
  • 2ab7e26: Future-proof mbox test
  • 016828d: webrev: fix indentation of removed binary file view
  • 5d474ee: Improve stripping of code blocks
  • cc79727: Add an issue link to RFR mails if the PR title contains one
  • 0132f0e: Add support for adding an issue when formatting the commit message

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Sep 24, 2019
@rwestberg
Copy link
Member Author

rwestberg commented Sep 24, 2019

Thanks for the reviews!

@rwestberg
Copy link
Member Author

rwestberg commented Sep 24, 2019

/integrate

@openjdk openjdk bot closed this Sep 24, 2019
@openjdk openjdk bot added the integrated label Sep 24, 2019
@openjdk
Copy link

openjdk bot commented Sep 24, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit 13c4308.

@openjdk openjdk bot removed the ready label Sep 24, 2019
@mlbridge
Copy link

mlbridge bot commented Sep 24, 2019

Mailing list message from duke duke@openjdk.java.net

Changeset: 13c4308
Author: Robin Westberg
Date: 2019-09-24 10:32:48 +0000
URL: https://git.openjdk.java.net/skara/commit/13c43083

102: Setting summary does not update the preview message

Reviewed-by: kcr, ehelin

! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/SummaryTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.