Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2088: Skara /reviewers command is no longer effective #1581

Closed
wants to merge 2 commits into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Nov 2, 2023

Hi all,

please review this fix for SKARA-2088. The fix consists of adding a special value (disable) to the key minimum in the [checks "reviewers"] subsection. This way the functionality enabled by the minimum key can be disabled by AdditionalConfiguration.java (since INI doesn't feature a way for keys to be unset).

I also made the ReviewersCheckConfiguration a bit more strict - the minimum key should never be combined with the keys lead, reviewers, committers, authors or contributors.

Finally I added tests for the above three scenarios.

Thanks,
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace

Issue

  • SKARA-2088: Skara /reviewers command is no longer effective (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/skara.git pull/1581/head:pull/1581
$ git checkout pull/1581

Update a local copy of the PR:
$ git checkout pull/1581
$ git pull https://git.openjdk.org/skara.git pull/1581/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1581

View PR using the GUI difftool:
$ git pr show -t 1581

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/skara/pull/1581.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 2, 2023

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title skara-2088 2088: Skara /reviewers command is no longer effective Nov 2, 2023
@openjdk openjdk bot added the rfr label Nov 2, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 2, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 2, 2023

@edvbld This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

2088: Skara /reviewers command is no longer effective

Reviewed-by: erikj, zsong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 0bbb956: 2091: CheckRun fails with NPE if github fullName is null
  • 1b290d8: 2083: Add option for omitting messages about /approval command

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 2, 2023
Copy link
Member

@zhaosongzs zhaosongzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@edvbld
Copy link
Member Author

edvbld commented Nov 2, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 2, 2023

Going to push as commit 410d4e5.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 0bbb956: 2091: CheckRun fails with NPE if github fullName is null
  • 1b290d8: 2083: Add option for omitting messages about /approval command

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Nov 2, 2023
@openjdk openjdk bot closed this Nov 2, 2023
@openjdk openjdk bot removed ready rfr labels Nov 2, 2023
@openjdk
Copy link

openjdk bot commented Nov 2, 2023

@edvbld Pushed as commit 410d4e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants