Adding project explanation #16

thegreystone · 2019-07-01T10:58:09Z

...as suggested in the Twitter discussion. :)

Progress

Change must not contain extraneous whitespace
Change must be properly reviewed

Approvers

Erik Helin (ehelin - Reviewer)


          Adding project explanation

bridgekeeper · 2019-07-01T10:58:18Z

Hi thegreystone, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user thegreystone as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

mlbridge · 2019-07-01T10:58:54Z

Webrevs

02: Full - Incremental (b77b890)
00: Full (4578553)


          Adding line breaks

mlbridge · 2019-07-01T11:13:27Z

Webrevs

01: Full - Incremental (6e020c8)

edvbld · 2019-07-01T13:38:12Z

🎉 🤣

❤️ indecisive bots!

thegreystone · 2019-07-01T14:14:03Z

That's a great band name right there - Indecisive Bots!

thegreystone · 2019-07-01T22:11:01Z

Here is the twitter discussion:
https://twitter.com/emilianbold/status/1143175227616239618?s=21

mlbridge · 2019-07-02T08:20:51Z

Mailing list message from Mario Torre neugens@redhat.com

...as suggested in the Twitter discussion. :)
🎉 🤣

Awesome, so now not only we need to track github as a whole, but also
twitter to get proper context for changesets! :)

I still think that the old good mailing list are the way to go ;)

Cheers,
Mario

--
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH https://www.redhat.com
9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898

mlbridge · 2019-07-02T08:20:51Z

Mailing list message from Erik Helin erik.helin@oracle.com

On 7/1/19 3:59 PM, Mario Torre wrote:

...as suggested in the Twitter discussion. :)
🎉 🤣

Awesome, so now not only we need to track github as a whole, but also
twitter to get proper context for changesets! :)

I was just about to ask Marcus to update the description for the patch,
as I don't follow nor use Twitter myself.

I think it is fairly obvious that we are still tuning a few knobs and
that Skara is under active development, making steady progress day by
day. We did run into a (pretty hilarious) Skara bug for this PR from
Marcus, to which I reacted with a comment containing a few emojis. The
comment was made in response to a number of label updates by the bots,
which is why the comment is out of context here on the mailing list.

I want to highlight that this not a normal situation, label updates on
pull requests do not in general convey enough useful information to
merit relaying them to a mailing list (nor comment on them). We
primarily use labels to aid people who want to sort pull requests in
various ways. We could send label updates to the mailing list as well,
but I think it would just annoy people (it would annoy me at least).

I still think that the old good mailing list are the way to go ;)

We also like mailing lists! I use skara-dev all the time to keep track
of patches, comments and discussion. I want to be very clear that the
goal is not to replace the mailing lists, we continue to work very
hard to ensure that a contributor who wishes to use the mailing lists
and the CLI should have a great experience.

The above doesn't mean we don't have a few bugs, Robin is currently
working on making the mailing list experience better. If you have any
additional feedback after following skara-dev then we'd be happy to hear
it! And as usual, if you see something you think is a bug, then please
file one 0.

Thanks,
Erik

README.md

mlbridge · 2019-07-03T12:39:51Z

Mailing list message from Marcus Hirt marcus@hirt.se

Haha. I mostly wanted to take it for a spin. Seems some good came out of it too. ;) I've updated the GitHub issue with a link to the discussion on Twitter.

Kind regards,
Marcus

-----Ursprungligt meddelande-----
Fr?n: Erik Helin <erik.helin at oracle.com>
Skickat: den 1 juli 2019 16:46
Till: Mario Torre ; Erik Duveblad via github.com
Kopia: skara-dev at openjdk.java.net; marcus at hirt.se
?mne: Re: RFR: Adding project explanation

On 7/1/19 3:59 PM, Mario Torre wrote:

...as suggested in the Twitter discussion. :)
🎉 🤣

Awesome, so now not only we need to track github as a whole, but also
twitter to get proper context for changesets! :)

I was just about to ask Marcus to update the description for the patch, as I don't follow nor use Twitter myself.

I think it is fairly obvious that we are still tuning a few knobs and that Skara is under active development, making steady progress day by day. We did run into a (pretty hilarious) Skara bug for this PR from Marcus, to which I reacted with a comment containing a few emojis. The comment was made in response to a number of label updates by the bots, which is why the comment is out of context here on the mailing list.

I want to highlight that this not a normal situation, label updates on pull requests do not in general convey enough useful information to merit relaying them to a mailing list (nor comment on them). We primarily use labels to aid people who want to sort pull requests in various ways. We could send label updates to the mailing list as well, but I think it would just annoy people (it would annoy me at least).

I still think that the old good mailing list are the way to go ;)

We also like mailing lists! I use skara-dev all the time to keep track of patches, comments and discussion. I want to be very clear that the goal is not to replace the mailing lists, we continue to work very hard to ensure that a contributor who wishes to use the mailing lists and the CLI should have a great experience.

The above doesn't mean we don't have a few bugs, Robin is currently working on making the mailing list experience better. If you have any additional feedback after following skara-dev then we'd be happy to hear it! And as usual, if you see something you think is a bug, then please file one 0.

Thanks,
Erik


          Update README.md

Co-Authored-By: Erik Duveblad <erik.helin@oracle.com>

edvbld · 2019-08-16T07:38:48Z

Thanks Marcus, the change looks good, but if you want to add me as contributor you need to use the /contributor command in a comment to list me as co-author:

/contributor add Erik Duveblad <ehelin@openjdk.java.net>

edvbld · 2019-08-16T07:51:41Z

Heh, I now realized (thanks to Robin) that you just incorporated my suggestion and that GitHub then automatically added me as co-author 😃 If you want to add me as co-author then you have to do as I described above, but I'm fine if you want to be sole author 😸

thegreystone · 2019-08-16T09:01:50Z

/contributor add Erik Duveblad ehelin@openjdk.java.net

openjdk · 2019-08-16T09:01:56Z

@thegreystone
Contributor Erik Duveblad <ehelin@openjdk.java.net> successfully added.

thegreystone · 2019-08-16T09:02:08Z

Done! :)

edvbld

Looks good

openjdk · 2019-08-16T10:54:56Z

@thegreystone This change can now be integrated. The commit message will be:

Adding project explanation

Co-authored-by: Erik Duveblad <ehelin@openjdk.java.net>
Reviewed-by: ehelin

If you would like to add a summary, use the /summary command.
To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 58 commits pushed to the master branch:

9c156f5: Expect carriage return to be part of lines when testing on Windows.
1c632fa: Allow output path to be created with arbitrary directory nesting
43d34cc: Avoid using getUrl when creating folder names
16c6536: Add ReadOnlyRepository::files
2a98c8a: Force unix line endings when writing patch files
24f3dde: Improve health check for git repositories
c582fb5: Do not catch NoSuchElementException in HgOpenJDKImport
256e498: Make ext.py compatible with hg5 api
6d6a0b6: A repository without refs but with objects is healthy
69d6b6b: Fix 2 failing tests due to URI syntax errors
b4b37e8: Fix some issues building on Windows
1b97234: Convert path separators in patch file to unix explicitly
0f1e47d: Parse list of repositories to mirror as a list
ac33f2f: Add support for ready markers to the PR bot as well
8467aae: 61: Remove sponsor label if PR is updated after flagged for integration
3e24d9c: 63: Remove the census cache
2e94eb0: 60: Add integrated to closed pull requests that have been integrated
f57fa46: Add Repository::revert
7623f82: Implement HgRepository::amend
db3e4c0: Fix another index out of bounds in webrev generation
0a354f4: 62: Proper parsing of GitLab discussions outside of a diff context
ef52825: Remove stray newline in HgRepository
c19224a: GitCommitIterator should handle empty commits
ef42f82: git combined diffs suffer from underflow
7a45536: Improve the previous empty hunks fix
6f88442: Fix webrev generation issue when a source hunk is empty
8f81e32: Cache the value of root() in GitRepository
f9979b0: Proper parsing of git diff --raw lines
d2e6beb: Use ZonedDateTime for date in Commit
b3d4d7c: Fix implementation of addremove
9d206dd: 59: Implement summary command
9325c74: 58: Add mirror and forward bots to skara-bots CLI image
71b944d: 57: The hgbridge should push marks to a configurable repository
39f574e: Improve testing of GitHub PositionMapper
d4ab5fd: 55: Reduce disk usage for notify bot
fbddc6f: 54: Add a mirror bot
3c5c3d8: 49: Add forwarder bot
8b41fd7: 50: Fix failing tests after e8d32c7
ab9a473: Use the web url in the displayed fetch command
2698709: 22: Wrong lines for comments
e8d32c7: Fix start of hunk range off-by-one error when parsing range string
1c8b488: Update README.md
83ad6c8: Get resource path from URI to avoid getting spurious leading path separator on Windows
53a6c51: 45: Fix remaining integration test issues
6746b03: 44: GitHubApplication should not use a JSONParser instance
90edbab: 43: Repository.get should return Optional.empty on non-existing directory
e83e473: 42: Notifier tests can fail depending on execution order
965be9c: 41: Bot launcher should detect ev. http proxy in environment
7c68b3b: 40: Fix failing tests after remote locking
0cfec57: 27: Push notification email should contain ev. sponsor
8a62fc9: 39: Use the lastUpdated field of pull requests to avoid unnecessary polls
fcbae43: 18: The fetch command in RFR emails does not work
81550df: 37: Make mailing list bridge ready check configurable
dc54456: 25: The GitHub parsePullRequestUrl method is not pattern aware
61fc564: 13: Add link to PR in emails to mailing list
0226b40: 34: Simplify Gradle proxy plugin
2a1e24b: 20: Do not send emails that a reviewer has added a comment
c704f49: Put the credentials lock in the remote repository

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@edvbld) but any other Committer may sponsor as well.

To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

edvbld · 2019-08-22T13:12:01Z

@thegreystone as the openjdk[bot] described above, you need to type the /integrate command in a comment to highlight that this PR is ready to be sponsored 😉

thegreystone · 2019-08-23T19:02:16Z

Oh dear.

thegreystone · 2019-08-23T19:02:23Z

/integrate

openjdk · 2019-08-23T19:02:34Z

@thegreystone
Your change (at version b77b890) is now ready to be sponsored by a Committer.

edvbld · 2019-08-26T06:12:51Z

/sponsor

openjdk · 2019-08-26T06:13:28Z

@edvbld @thegreystone The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit 20c3f55.

Adding project explanation

Loading status checks…

4578553

bridgekeeper bot added the oca label Jul 1, 2019

openjdk bot added rfr and removed rfr labels Jul 1, 2019

Adding line breaks

Loading status checks…

6e020c8

bridgekeeper bot removed the oca label Jul 1, 2019

openjdk bot added the rfr label Jul 1, 2019

bridgekeeper bot added the oca label Jul 1, 2019

openjdk bot removed the rfr label Jul 1, 2019

bridgekeeper bot removed the oca label Jul 1, 2019

openjdk bot added the rfr label Jul 1, 2019

bridgekeeper bot added the oca label Jul 1, 2019

openjdk bot removed the rfr label Jul 1, 2019

bridgekeeper bot removed the oca label Jul 1, 2019

openjdk bot added the rfr label Jul 1, 2019

edvbld reviewed Jul 3, 2019

View changes

README.md Outdated Show resolved Hide resolved

Update README.md

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

Loading status checks…

b77b890

Co-Authored-By: Erik Duveblad <erik.helin@oracle.com>

edvbld approved these changes Aug 16, 2019

View changes

openjdk bot removed the rfr label Aug 16, 2019

openjdk bot added the ready label Aug 16, 2019

edvbld assigned thegreystone Aug 23, 2019

openjdk bot added the sponsor label Aug 23, 2019

openjdk bot closed this Aug 26, 2019

openjdk bot added the integrated label Aug 26, 2019

openjdk / skara

Adding project explanation #16

Adding project explanation #16

thegreystone commented Jul 1, 2019 •

edited by openjdk bot

bridgekeeper bot commented Jul 1, 2019

mlbridge bot commented Jul 1, 2019 •

edited

mlbridge bot commented Jul 1, 2019 •

edited by bridgekeeper bot

edvbld commented Jul 1, 2019 •

edited

thegreystone commented Jul 1, 2019

thegreystone commented Jul 1, 2019

mlbridge bot commented Jul 2, 2019

mlbridge bot commented Jul 2, 2019

mlbridge bot commented Jul 3, 2019

edvbld commented Aug 16, 2019

edvbld commented Aug 16, 2019

thegreystone commented Aug 16, 2019

openjdk bot commented Aug 16, 2019

thegreystone commented Aug 16, 2019

edvbld left a comment

openjdk bot commented Aug 16, 2019 •

edited

edvbld commented Aug 22, 2019

thegreystone commented Aug 23, 2019

thegreystone commented Aug 23, 2019

openjdk bot commented Aug 23, 2019

edvbld commented Aug 26, 2019

openjdk bot commented Aug 26, 2019

openjdk / skara

Join GitHub today

Adding project explanation #16

Adding project explanation #16

Conversation

thegreystone commented Jul 1, 2019 • edited by openjdk bot

Progress

Approvers

bridgekeeper bot commented Jul 1, 2019

mlbridge bot commented Jul 1, 2019 • edited

Webrevs

mlbridge bot commented Jul 1, 2019 • edited by bridgekeeper bot

Webrevs

edvbld commented Jul 1, 2019 • edited

thegreystone commented Jul 1, 2019

thegreystone commented Jul 1, 2019

mlbridge bot commented Jul 2, 2019

mlbridge bot commented Jul 2, 2019

mlbridge bot commented Jul 3, 2019

edvbld commented Aug 16, 2019

edvbld commented Aug 16, 2019

thegreystone commented Aug 16, 2019

openjdk bot commented Aug 16, 2019

thegreystone commented Aug 16, 2019

edvbld left a comment

openjdk bot commented Aug 16, 2019 • edited

edvbld commented Aug 22, 2019

thegreystone commented Aug 23, 2019

thegreystone commented Aug 23, 2019

openjdk bot commented Aug 23, 2019

edvbld commented Aug 26, 2019

openjdk bot commented Aug 26, 2019

thegreystone commented Jul 1, 2019 •

edited by openjdk bot

mlbridge bot commented Jul 1, 2019 •

edited

mlbridge bot commented Jul 1, 2019 •

edited by bridgekeeper bot

edvbld commented Jul 1, 2019 •

edited

openjdk bot commented Aug 16, 2019 •

edited