New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding project explanation #16
Conversation
Hi thegreystone, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user thegreystone as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
Webrevs
|
Webrevs
|
|
That's a great band name right there - Indecisive Bots! |
Here is the twitter discussion: |
Mailing list message from Mario Torre neugens@redhat.com
Awesome, so now not only we need to track github as a whole, but also I still think that the old good mailing list are the way to go ;) Cheers, -- |
Mailing list message from Erik Helin erik.helin@oracle.com On 7/1/19 3:59 PM, Mario Torre wrote:
I was just about to ask Marcus to update the description for the patch, I think it is fairly obvious that we are still tuning a few knobs and I want to highlight that this not a normal situation, label updates on
We also like mailing lists! I use skara-dev all the time to keep track The above doesn't mean we don't have a few bugs, Robin is currently Thanks, |
Mailing list message from Marcus Hirt marcus@hirt.se Haha. I mostly wanted to take it for a spin. Seems some good came out of it too. ;) I've updated the GitHub issue with a link to the discussion on Twitter. Kind regards, -----Ursprungligt meddelande----- On 7/1/19 3:59 PM, Mario Torre wrote:
I was just about to ask Marcus to update the description for the patch, as I don't follow nor use Twitter myself. I think it is fairly obvious that we are still tuning a few knobs and that Skara is under active development, making steady progress day by day. We did run into a (pretty hilarious) Skara bug for this PR from Marcus, to which I reacted with a comment containing a few emojis. The comment was made in response to a number of label updates by the bots, which is why the comment is out of context here on the mailing list. I want to highlight that this not a normal situation, label updates on pull requests do not in general convey enough useful information to merit relaying them to a mailing list (nor comment on them). We primarily use labels to aid people who want to sort pull requests in various ways. We could send label updates to the mailing list as well, but I think it would just annoy people (it would annoy me at least).
We also like mailing lists! I use skara-dev all the time to keep track of patches, comments and discussion. I want to be very clear that the goal is not to replace the mailing lists, we continue to work very hard to ensure that a contributor who wishes to use the mailing lists and the CLI should have a great experience. The above doesn't mean we don't have a few bugs, Robin is currently working on making the mailing list experience better. If you have any additional feedback after following skara-dev then we'd be happy to hear it! And as usual, if you see something you think is a bug, then please file one 0. Thanks, |
Co-Authored-By: Erik Duveblad <erik.helin@oracle.com>
Thanks Marcus, the change looks good, but if you want to add me as contributor you need to use the
|
Heh, I now realized (thanks to Robin) that you just incorporated my suggestion and that GitHub then automatically added me as co-author |
/contributor add Erik Duveblad ehelin@openjdk.java.net |
@thegreystone |
Done! :) |
@thegreystone This change can now be integrated. The commit message will be:
Since the source branch of this PR was last updated there have been 58 commits pushed to the
Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@edvbld) but any other Committer may sponsor as well.
|
@thegreystone as the |
Oh dear. |
/integrate |
@thegreystone |
/sponsor |
@edvbld @thegreystone The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. |
...as suggested in the Twitter discussion. :)
Progress
Approvers