Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper mime encoding of high ascii strings #161

Closed
wants to merge 1 commit into from

Conversation

@rwestberg
Copy link
Member

rwestberg commented Sep 25, 2019

Hi all,

Please review this change that ensures that all high ascii strings that are sent in emails are properly mime encoded. Before, this was only done when writing mbox archives.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)
@bridgekeeper

This comment has been minimized.

Copy link

bridgekeeper bot commented Sep 25, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Sep 25, 2019
@mlbridge

This comment has been minimized.

Copy link

mlbridge bot commented Sep 25, 2019

Webrevs

@edvbld
edvbld approved these changes Sep 25, 2019
Copy link
Member

edvbld left a comment

Wow, nice work! Looks good, thanks for fixing!

@openjdk openjdk bot removed the rfr label Sep 25, 2019
@openjdk

This comment has been minimized.

Copy link

openjdk bot commented Sep 25, 2019

@rwestberg This change can now be integrated. The commit message will be:

Proper mime encoding of high ascii strings

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Sep 25, 2019
@rwestberg

This comment has been minimized.

Copy link
Member Author

rwestberg commented Sep 25, 2019

/integrate

@openjdk openjdk bot closed this Sep 25, 2019
@openjdk openjdk bot added the integrated label Sep 25, 2019
@openjdk

This comment has been minimized.

Copy link

openjdk bot commented Sep 25, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit 76d0158.

@openjdk openjdk bot removed the ready label Sep 25, 2019
@mlbridge

This comment has been minimized.

Copy link

mlbridge bot commented Sep 25, 2019

Mailing list message from duke duke@openjdk.java.net

Changeset: 76d0158
Author: Robin Westberg
Date: 2019-09-25 08:15:32 +0000
URL: https://git.openjdk.java.net/skara/commit/76d0158a

Proper mime encoding of high ascii strings

Reviewed-by: ehelin

! email/src/main/java/org/openjdk/skara/email/Email.java

  • email/src/main/java/org/openjdk/skara/email/MimeText.java
    ! email/src/main/java/org/openjdk/skara/email/SMTP.java
    ! email/src/test/java/org/openjdk/skara/email/EmailTests.java
  • email/src/test/java/org/openjdk/skara/email/MimeTextTests.java
    ! email/src/test/java/org/openjdk/skara/email/SMTPTests.java
    ! mailinglist/src/main/java/org/openjdk/skara/mailinglist/Mbox.java
    ! test/src/main/java/org/openjdk/skara/test/SMTPServer.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.