Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2190: Setting maximum size limit for PR diff in generating Webrev #1617

Closed
wants to merge 8 commits into from

Conversation

zhaosongzs
Copy link
Member

@zhaosongzs zhaosongzs commented Mar 4, 2024

openjdk/tsan#17, there are more than 5000 commits in this pr and mlbridge bot was trying to generate the webrev. The generation of webrev was successful but the webrev file was too big and exceeded GitHub's file size limit.

So as ErikJ suggested, if the diff of the pr is too large, we shouldn't generate webrev for it.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace

Issue

  • SKARA-2190: Setting maximum size limit for PR diff in generating Webrev (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/skara.git pull/1617/head:pull/1617
$ git checkout pull/1617

Update a local copy of the PR:
$ git checkout pull/1617
$ git pull https://git.openjdk.org/skara.git pull/1617/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1617

View PR using the GUI difftool:
$ git pr show -t 1617

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/skara/pull/1617.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 4, 2024

👋 Welcome back zsong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title SKARA-2190 2190: Setting maximum size limit for PR diff in generating Webrev Mar 4, 2024
@zhaosongzs zhaosongzs marked this pull request as ready for review March 7, 2024 00:51
@openjdk openjdk bot added the rfr label Mar 7, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 7, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 8, 2024

@zhaosongzs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

2190: Setting maximum size limit for PR diff in generating Webrev

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 7b937ab: 2189: Mark command as handled when JCheckConfiguration is missing or invalid in PullRequestCommandWorkItem

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 8, 2024
@zhaosongzs
Copy link
Member Author

Thanks for the review!
/integrate

@openjdk
Copy link

openjdk bot commented Mar 8, 2024

Going to push as commit af682b4.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 7b937ab: 2189: Mark command as handled when JCheckConfiguration is missing or invalid in PullRequestCommandWorkItem

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 8, 2024
@openjdk openjdk bot closed this Mar 8, 2024
@openjdk openjdk bot removed ready rfr labels Mar 8, 2024
@openjdk
Copy link

openjdk bot commented Mar 8, 2024

@zhaosongzs Pushed as commit af682b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@erikj79
Copy link
Member

erikj79 commented Mar 8, 2024

Test comment, please ignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants