Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2210: Use authenticatedUrl instead of webUrl in MergeBot #1624

Closed
wants to merge 1 commit into from

Conversation

zhaosongzs
Copy link
Member

@zhaosongzs zhaosongzs commented Mar 25, 2024

Since the bot uses ssh to clone the repos in MergeBot, the bot should also use authenticatedUrl(ssh url) to access the remote repo. However, the mergeBot is still using webUrl(https url) in some places and it triggered an issue today.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace

Issue

  • SKARA-2210: Use authenticatedUrl instead of webUrl in MergeBot (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/skara.git pull/1624/head:pull/1624
$ git checkout pull/1624

Update a local copy of the PR:
$ git checkout pull/1624
$ git pull https://git.openjdk.org/skara.git pull/1624/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1624

View PR using the GUI difftool:
$ git pr show -t 1624

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/skara/pull/1624.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2024

👋 Welcome back zsong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

@zhaosongzs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

2210: Use authenticatedUrl instead of webUrl in MergeBot

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title SKARA-2210 2210: Use authenticatedUrl instead of webUrl in MergeBot Mar 25, 2024
@zhaosongzs zhaosongzs marked this pull request as ready for review March 25, 2024 18:01
@openjdk openjdk bot added the rfr label Mar 25, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2024

Webrevs

@openjdk openjdk bot added the ready label Mar 25, 2024
@zhaosongzs
Copy link
Member Author

Thanks!
/integrate

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

Going to push as commit 7fbecfa.

@openjdk openjdk bot added the integrated label Mar 25, 2024
@openjdk openjdk bot closed this Mar 25, 2024
@openjdk
Copy link

openjdk bot commented Mar 25, 2024

@zhaosongzs Pushed as commit 7fbecfa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants