Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

52: The HgToGitConverter waits for child processes indefinitely #165

Closed
wants to merge 1 commit into from

Conversation

@rwestberg
Copy link
Member

rwestberg commented Sep 27, 2019

Hi all,

Please review this small change that adds a timeout to the HgToGitConverter, as it seems that intermittent network problems can cause the child processes to hang.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 27, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Sep 27, 2019
@mlbridge
Copy link

mlbridge bot commented Sep 27, 2019

Webrevs

@edvbld
edvbld approved these changes Sep 30, 2019
Copy link
Member

edvbld left a comment

Looks good, thanks for fixing this!

@openjdk openjdk bot removed the rfr label Sep 30, 2019
@openjdk
Copy link

openjdk bot commented Sep 30, 2019

@rwestberg This change can now be integrated. The commit message will be:

52: The HgToGitConverter waits for child processes indefinitely

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • 8b659d3: The test mailman server should handle utf-8 encoded content
  • ffc5e6c: Email body should not be mime encoded

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Sep 30, 2019
@rwestberg
Copy link
Member Author

rwestberg commented Sep 30, 2019

/integrate

@openjdk openjdk bot closed this Sep 30, 2019
@openjdk openjdk bot added integrated and removed ready labels Sep 30, 2019
@openjdk
Copy link

openjdk bot commented Sep 30, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit a8f991e.

@mlbridge
Copy link

mlbridge bot commented Sep 30, 2019

Mailing list message from duke duke@openjdk.java.net

Changeset: a8f991e
Author: Robin Westberg
Date: 2019-09-30 12:38:57 +0000
URL: https://git.openjdk.java.net/skara/commit/a8f991e7

52: The HgToGitConverter waits for child processes indefinitely

Reviewed-by: ehelin

! vcs/src/main/java/org/openjdk/skara/vcs/openjdk/convert/HgToGitConverter.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.