Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CheckBuilder::from #175

Closed
wants to merge 1 commit into from
Closed

Add CheckBuilder::from #175

wants to merge 1 commit into from

Conversation

@edvbld
Copy link
Member

edvbld commented Oct 2, 2019

Hi all,

this small patch adds the method CheckBuilder::from that allows a CheckBuilder to be initialized to all the values from an existing Check, thereby enabling modifying a Check (while still preserving the old Check).

Testing

  • sh gradlew test passes
  • Added one new unit test

Thanks,
Erik

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 2, 2019

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added rfr build labels Oct 2, 2019
@mlbridge
Copy link

mlbridge bot commented Oct 2, 2019

Webrevs

Copy link
Member

rwestberg left a comment

Looks good!

@openjdk openjdk bot removed the rfr label Oct 2, 2019
@openjdk
Copy link

openjdk bot commented Oct 2, 2019

@edvbld This change can now be integrated. The commit message will be:

Add CheckBuilder::from

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • 78dcf94: Batch add tags in the notifier bot
  • 80cc247: Add issue information to the PR summary

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Oct 2, 2019
@edvbld
Copy link
Member Author

edvbld commented Oct 2, 2019

/integrate

@openjdk openjdk bot closed this Oct 2, 2019
@openjdk openjdk bot added integrated and removed ready labels Oct 2, 2019
@openjdk
Copy link

openjdk bot commented Oct 2, 2019

@edvbld The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit 667f26e.

@mlbridge
Copy link

mlbridge bot commented Oct 2, 2019

Mailing list message from duke duke@openjdk.java.net

Changeset: 667f26e
Author: Erik Helin
Date: 2019-10-02 08:53:34 +0000
URL: https://git.openjdk.java.net/skara/commit/667f26e6

Add CheckBuilder::from

Reviewed-by: rwestberg

! host/build.gradle
! host/src/main/java/org/openjdk/skara/host/CheckBuilder.java

  • host/src/test/java/org/openjdk/skara/host/CheckBuilderTests.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.