Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to cancel a Check #180

Closed
wants to merge 2 commits into from

Conversation

@edvbld
Copy link
Member

edvbld commented Oct 3, 2019

Hi all,

this patch became a bit larger than I initially thought. I added a new CheckState - CANCELLED and a new method to CheckBuider - cancel(). However to fully support this I needed to quite a bit of refactoring in both GitHubPullRequest and GitLabMergeRequest so that createCheck allows checks with all kinds of states to be created.

Testing

  • sh gradlew test passes on Linux x86_64
  • Added one new unit test
  • sh gradlew test with credentials mostly passes against both GitHub and GitLab (there are a few known failures)

Thanks,
Erik

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

@edvbld edvbld changed the title Make it possible cancel a Check Make it possible to cancel a Check Oct 3, 2019
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2019

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added rfr bots labels Oct 3, 2019
@mlbridge
Copy link

mlbridge bot commented Oct 3, 2019

Webrevs

Copy link
Member

rwestberg left a comment

Looks good, thanks for fixing!

@openjdk openjdk bot removed the rfr label Oct 4, 2019
@openjdk
Copy link

openjdk bot commented Oct 4, 2019

@edvbld This change can now be integrated. The commit message will be:

Make it possible to cancel a Check

Co-authored-by: Robin Westberg <robin.westberg@oracle.com>
Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 4 commits pushed to the master branch:

  • 1bf3e51: Use patterns for branches to notify instead of a list
  • 0bda3a4: Fix build failure after rebase
  • 3475db9: Post specific review comments before generic ones
  • 59f04e4: Implement basic support for the Jira issue tracker

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Oct 4, 2019
Co-Authored-By: Robin Westberg <robin@westberg.se>
@edvbld
Copy link
Member Author

edvbld commented Oct 4, 2019

/contributor help

@openjdk
Copy link

openjdk bot commented Oct 4, 2019

@edvbld Syntax: /contributor (add|remove) Full Name <email@address>

@edvbld
Copy link
Member Author

edvbld commented Oct 4, 2019

/contributor add Robin Westberg robin.westberg@oracle.com

@openjdk
Copy link

openjdk bot commented Oct 4, 2019

@edvbld
Contributor Robin Westberg <robin.westberg@oracle.com> successfully added.

@edvbld
Copy link
Member Author

edvbld commented Oct 4, 2019

/integrate

@openjdk openjdk bot closed this Oct 4, 2019
@openjdk openjdk bot added the integrated label Oct 4, 2019
@openjdk
Copy link

openjdk bot commented Oct 4, 2019

@edvbld The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit fc52685.

@openjdk openjdk bot removed the ready label Oct 4, 2019
@mlbridge
Copy link

mlbridge bot commented Oct 4, 2019

Mailing list message from duke duke@openjdk.java.net

Changeset: fc52685
Author: Erik Helin
Date: 2019-10-04 07:29:31 +0000
URL: https://git.openjdk.java.net/skara/commit/fc526853

Make it possible to cancel a Check

Co-authored-by: Robin Westberg <robin.westberg at oracle.com>
Reviewed-by: rwestberg

! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java
! host/src/main/java/org/openjdk/skara/host/CheckBuilder.java
! host/src/main/java/org/openjdk/skara/host/CheckStatus.java
! host/src/main/java/org/openjdk/skara/host/github/GitHubPullRequest.java
! host/src/main/java/org/openjdk/skara/host/gitlab/GitLabMergeRequest.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.