Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper markdown formatting of issue link #184

Closed
wants to merge 1 commit into from

Conversation

@rwestberg
Copy link
Member

@rwestberg rwestberg commented Oct 4, 2019

Hi all,

Please review this trivial fix that properly formats the issue link in pull request summaries.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 4, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added rfr bots labels Oct 4, 2019
@edvbld
edvbld approved these changes Oct 4, 2019
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 4, 2019

Webrevs

@openjdk openjdk bot removed the rfr label Oct 4, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Oct 4, 2019

@rwestberg This change can now be integrated. The commit message will be:

Proper markdown formatting of issue link

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Oct 4, 2019
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Oct 4, 2019

/integrate

@openjdk openjdk bot closed this Oct 4, 2019
@openjdk openjdk bot added integrated and removed ready labels Oct 4, 2019
@openjdk
Copy link

@openjdk openjdk bot commented Oct 4, 2019

@rwestberg Pushed as commit 223b20d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants